Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binary subtypes #2908

Merged
merged 16 commits into from
Aug 14, 2021
Merged

Fix binary subtypes #2908

merged 16 commits into from
Aug 14, 2021

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Aug 1, 2021 •
edited
Loading

  • Fix return value of subtype() function in case no subtype is set.
  • Add unit tests for byte_container_with_subtype class.
  • Add support for CBOR to store binary subtypes.

@nlohmann nlohmann marked this pull request as draft August 1, 2021 20:02
@nlohmann nlohmann self-assigned this Aug 1, 2021
@nlohmann nlohmann linked an issue Aug 1, 2021 that may be closed by this pull request
Binary subtype field cannot represent all CBOR tags #2863
Closed
@nlohmann nlohmann mentioned this pull request Aug 1, 2021
Closed
@nlohmann nlohmann added the aspect: binary formats BSON, CBOR, MessagePack, UBJSON label Aug 1, 2021
@coveralls
Copy link

coveralls commented Aug 1, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 1aceeff on issue2863 into 6ac037c on develop.

@nlohmann nlohmann marked this pull request as ready for review August 7, 2021 12:47
@nlohmann nlohmann added this to the Release 3.9.2 milestone Aug 11, 2021
@nlohmann nlohmann merged commit 1300d2e into develop Aug 14, 2021
@nlohmann nlohmann deleted the issue2863 branch August 14, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
aspect: binary formats BSON, CBOR, MessagePack, UBJSON release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.10.0
Development

Successfully merging this pull request may close these issues.

Binary subtype field cannot represent all CBOR tags
2 participants
@nlohmann @coveralls