Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 fix gdb_pretty_printer failure on basic types #2950

Merged
merged 1 commit into from
Aug 18, 2021
Merged

🚨 fix gdb_pretty_printer failure on basic types #2950

merged 1 commit into from
Aug 18, 2021

Conversation

senyai
Copy link
Contributor

@senyai senyai commented Aug 18, 2021

name can be None, and re.search fails on None;
replaced re by str.startswith and str.endswith

@senyai
🚨 gdb_pretty_printer failure on basic types
355fa6c 
name can be None, and `re.search` fails on `None`;
replaced `re` by `str.startswith` and `str.endswith`
@senyai senyai requested a review from nlohmann as a code owner August 18, 2021 16:31
@senyai senyai changed the title 🚨 gdb_pretty_printer failure on basic types 🚨 fix gdb_pretty_printer failure on basic types Aug 18, 2021
nlohmann
nlohmann approved these changes Aug 18, 2021
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Aug 18, 2021
@nlohmann nlohmann added this to the Release 3.10.1 milestone Aug 18, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 355fa6c on senyai:patch-2 into f42a74b on nlohmann:develop.

@nlohmann nlohmann merged commit abd829e into nlohmann:develop Aug 18, 2021
@nlohmann
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@senyai @coveralls @nlohmann