Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling #3125

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fix spelling #3125

merged 1 commit into from
Nov 9, 2021

Conversation

axic
Copy link
Contributor

@axic axic commented Nov 6, 2021

I am trying to use the single_include version of this library in a project (here), and to simplify matters I thought to just include the file (or perhaps via subtree).

This means most of the linter tools run on the project would check this file. This is how I found the following complaints from codespell. I certainly can exclude this file from that tool, but thought it may be useful here too.

@axic axic requested a review from nlohmann as a code owner November 6, 2021 22:45
@coveralls
Copy link

coveralls commented Nov 7, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 959d69f on axic:codespell into 5c08a52 on nlohmann:develop.

@nlohmann
Copy link
Owner

nlohmann commented Nov 7, 2021

The CI failed: You need to edit the individual files in the include directory and then execute make amalgamate to create the single header.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the files in include and call make amalgamate to create the single header.

@axic
Copy link
Contributor Author

axic commented Nov 7, 2021

Please edit the files in include and call make amalgamate to create the single header.

I though I ran it, but apparently didn't. Fixed now.

@axic axic requested a review from nlohmann November 7, 2021 17:40
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann
Copy link
Owner

nlohmann commented Nov 7, 2021

Thanks a lot! I will merge once the CI is done.

@nlohmann nlohmann merged commit 8349180 into nlohmann:develop Nov 9, 2021
@axic axic deleted the codespell branch November 9, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants