Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note on parsing ordered_json #3326

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Add note on parsing ordered_json #3326

merged 1 commit into from
Feb 12, 2022

Conversation

nlohmann
Copy link
Owner

Fixes #3325.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 59df006 on issue3325_ordered_json_doc into eb21824 on develop.

@nlohmann
Copy link
Owner Author

@gregmarr Is this what you had in mind?

@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Feb 11, 2022
gregmarr
gregmarr approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@gregmarr gregmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@nlohmann nlohmann self-assigned this Feb 12, 2022
@nlohmann nlohmann added this to the Release 3.10.6 milestone Feb 12, 2022
@nlohmann nlohmann merged commit d8a6329 into develop Feb 12, 2022
@nlohmann nlohmann deleted the issue3325_ordered_json_doc branch February 12, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change review needed It would be great if someone could review the proposed changes.
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

Documentation for ordered_json should show proper use of the parse() function.
3 participants
@nlohmann @coveralls @gregmarr