Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unit tests to use more convenient doctest assertion macros (Part 2) #3405

Merged
merged 6 commits into from
Apr 1, 2022
Merged

Refactor unit tests to use more convenient doctest assertion macros (Part 2) #3405

merged 6 commits into from
Apr 1, 2022

Conversation

kkarbowiak
Copy link
Contributor

Also, removed some now redundant code and adjusted the expected error messages. The new messages reflect what would be communicated if the old assertion macros were reordered (first CHECK_THROWS_WITH and then CHECK_THROWS_AS).

@coveralls
Copy link

coveralls commented Mar 30, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a7f0448 on kkarbowiak:develop into 66f6b4b on nlohmann:develop.

nlohmann
nlohmann approved these changes Apr 1, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 1, 2022
@nlohmann nlohmann added this to the Release 3.10.6 milestone Apr 1, 2022
@nlohmann nlohmann linked an issue Apr 1, 2022 that may be closed by this pull request
Refactor unit tests to use more convenient doctest assertion macros #3365
Closed
@nlohmann nlohmann merged commit 3b16057 into nlohmann:develop Apr 1, 2022
@nlohmann
Copy link
Owner

nlohmann commented Apr 1, 2022

Thanks!

@kkarbowiak
Copy link
Contributor Author

Thank you for taking the time to review and accept the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmarr gregmarr gregmarr left review comments

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

Refactor unit tests to use more convenient doctest assertion macros
4 participants
@kkarbowiak @coveralls @nlohmann @gregmarr