Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: speedup AppVeyor builds by ~30% #3422

Merged
merged 1 commit into from
Apr 6, 2022
Merged

CI: speedup AppVeyor builds by ~30% #3422

merged 1 commit into from
Apr 6, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

@falbrechtskirchinger falbrechtskirchinger commented Apr 5, 2022 •
edited
Loading

AppVeyor build VMs should provide at least two cores. Parallelize builds
and tests.
In addition, enable output on failure and disable verbose test output.

I'm starting with 2 parallel jobs (known speed-up) and will then test with 3.

@falbrechtskirchinger
CI: speedup AppVeyor builds by ~30%
4154928 
AppVeyor build VMs should provide at least two cores. Parallelize builds
and tests.
In addition, enable output on failure and disable verbose test output.
@coveralls
Copy link

coveralls commented Apr 5, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4154928 on falbrechtskirchinger:speedup-appveyor into ab5cecb on nlohmann:develop.

@falbrechtskirchinger
Copy link
Contributor Author

falbrechtskirchinger commented Apr 5, 2022 •
edited
Loading

# Jobs Time Improvement over 1
1 2h30 -
2 1h40 ~33%
3 1h40 ~33%

Ok. 2 parallel jobs it is.

nlohmann
nlohmann approved these changes Apr 6, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 6, 2022
@nlohmann nlohmann added this to the Release 3.10.6 milestone Apr 6, 2022
@nlohmann nlohmann merged commit fa91409 into nlohmann:develop Apr 6, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the speedup-appveyor branch April 6, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@falbrechtskirchinger @coveralls @nlohmann