Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude std::any from implicit conversion (fixes #3428) #3437

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Exclude std::any from implicit conversion (fixes #3428) #3437

merged 2 commits into from
Apr 12, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Fixes #3428 (MSVC) and silences compiler warning on GCC (-Wconversion).

@falbrechtskirchinger
Exclude std::any from implicit conversion
6ea011f 
Fixes nlohmann#3428 (MSVC) and silences compiler warning on GCC (-Wconversion).
@coveralls
Copy link

coveralls commented Apr 12, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a41b003 on falbrechtskirchinger:fix-issue-3428 into 1034490 on nlohmann:develop.

nlohmann
nlohmann approved these changes Apr 12, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 12, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Apr 12, 2022
@nlohmann nlohmann merged commit 1deeb43 into nlohmann:develop Apr 12, 2022
@nlohmann
Copy link
Owner

Thanks!

@falbrechtskirchinger falbrechtskirchinger deleted the fix-issue-3428 branch April 12, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🐛 bug fix
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

Error occurred when converting nlohmann::json to std::any
3 participants
@falbrechtskirchinger @coveralls @nlohmann