Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable regression test for #3070 on GCC <8.4 #3451

Merged

Conversation

falbrechtskirchinger
Copy link
Contributor

Disables part of the regression test for #3070 on GCC <8.4 (already disabled for MSVC).
Discussed here.

Once again, the ambiguous overload resolution isn't something we can fix (easily, if at all).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7cd3120 on falbrechtskirchinger:disable-test-3070-gcc-84 into a944306 on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Apr 22, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Apr 22, 2022
@nlohmann nlohmann merged commit 1a90c94 into nlohmann:develop Apr 22, 2022
@nlohmann
Copy link
Owner

Thanks!

@falbrechtskirchinger falbrechtskirchinger deleted the disable-test-3070-gcc-84 branch April 22, 2022 12:21
@LeSpocky
Copy link

LeSpocky commented Jul 5, 2022

Currently building on Debian GNU/Linux 10 (buster) here, and hence stumbled over this. Will this be backported to the 3.10.x branch?

@nlohmann
Copy link
Owner

nlohmann commented Jul 5, 2022

No, we will not backport changes. This will be fixed in the 3.11.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants