Add unit test to make sure iterator_input_adapter advances iterators correctly #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falbrechtskirchinger
force-pushed
the
iterator-unit-test
branch
from
63f6eec
to
bb9eda1
Compare
|
@nlohmann @gregmarr This PR is a proactive step to make sure the iterator position after parsing reflects expectations [1]. I hope the parse API can be changed or amended in the future to return the iterator to where parsing stopped. This is in clear conflict with #3442, which aims to change this to point to the last processed character. [1] To be fair, those are my expectations but I believe they're reasonable. |
When parsing a string containing two JSON values using iterators, after parsing, iterator_input_adapter should have advanced to the first character of the second value. Add a unit test to check that this is true.
falbrechtskirchinger
force-pushed
the
iterator-unit-test
branch
from
bb9eda1
to
3458089
Compare
4 tasks
|
@nlohmann Ping. Do you need me to do anything here? |
|
Thanks for reminding me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a string containing two JSON values using iterators, after parsing,
iterator_input_adaptershould have advanced to the first character of the second value.The current API doesn't return the
firstiterator after parsing. To achieve the same effect aproxy_iteratoris added that advances the iterator passed by reference, even if the proxy is moved.