Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unit test including windows.h #3631

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Add a unit test including windows.h #3631

merged 1 commit into from
Jul 31, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Add a unit test to catch issues when <windows.h> is included.

This is not handled by AppVeyor despite some code in appveyor.yml suggesting otherwise.

@falbrechtskirchinger
Copy link
Contributor Author

Windows builds should fail without #3630.

@coveralls
Copy link

coveralls commented Jul 30, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 90c4355 on falbrechtskirchinger:windows into fc3e64c on nlohmann:develop.

@falbrechtskirchinger
Copy link
Contributor Author

Next build is expected to succeed.

nlohmann
nlohmann approved these changes Jul 30, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 30, 2022
@nlohmann nlohmann added this to the Release 3.11.0 milestone Jul 30, 2022
@nlohmann nlohmann merged commit 66c8bb5 into nlohmann:develop Jul 31, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the windows branch July 31, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@falbrechtskirchinger @coveralls @nlohmann