Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_natvis.py: validate version number; cleanup #3698

Merged
merged 1 commit into from
Aug 12, 2022
Merged

generate_natvis.py: validate version number; cleanup #3698

merged 1 commit into from
Aug 12, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

This was meant to be part of #3697 but didn't get in before the merge. Not critical.

nlohmann
nlohmann approved these changes Aug 12, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-actions github-actions bot added the M label Aug 12, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fe38e60 on falbrechtskirchinger:inline-ns-natvis into c0dae0f on nlohmann:develop.

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 12, 2022
@nlohmann nlohmann merged commit 32bbd38 into nlohmann:develop Aug 12, 2022
@falbrechtskirchinger falbrechtskirchinger deleted the inline-ns-natvis branch August 12, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
M
Projects
None yet
Milestone
Release 3.11.2
Development

Successfully merging this pull request may close these issues.
3 participants
@falbrechtskirchinger @coveralls @nlohmann