Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI checks #4215

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Conversation

colbychaskell
Copy link
Contributor

@colbychaskell colbychaskell commented Nov 25, 2023

Multiple CI checks have been failing because of an issue using the lukka/get-cmake action in the CI workflow. The latest version of lukka/get-cmake uses node20 instead of node16 so it requires higher versions of the c standard libraries. To keep this working with the older GCC versions, I have specified the previous version of the lukka/get-cmake.

There also seems to be a new failing clang tidy check in one of the tests due to a static cast to a derived type. I assume this is due to the jobs container updating the clang tidy version. Added a NOLINT to this line to get the CI passing for now.


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@nlohmann
Copy link
Owner

Thanks a lot! L

@colbychaskell colbychaskell changed the title Fix get CMake/Ninja job in CI Fix failing CI checks Nov 25, 2023
@colbychaskell colbychaskell force-pushed the fix-ci-get-cmake branch 6 times, most recently from 6d6b285 to 5ddb15d Compare November 25, 2023 16:06
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 1c41daa on colbychaskell:fix-ci-get-cmake
into 6eab7a2 on nlohmann:develop.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Nov 25, 2023
@nlohmann nlohmann merged commit 5d931c5 into nlohmann:develop Nov 25, 2023
109 of 111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants