Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get username and key file from ssh config files for SFTP #367

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

wayhoww
Copy link
Contributor

@wayhoww wayhoww commented Jul 13, 2024

By adding this feature we can sync via SFTP by simply invoking command like:

gofs  -source="./source" -dest="sftp://host?remote_path=/path/to/dest"

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 32.91%. Comparing base (5309c6f) to head (5a50f3b).

Files Patch % Lines
core/vfs.go 88.63% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   32.53%   32.91%   +0.38%     
==========================================
  Files         133      133              
  Lines        6059     6101      +42     
==========================================
+ Hits         1971     2008      +37     
- Misses       3997     4000       +3     
- Partials       91       93       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstmdev mstmdev requested review from mstmdev and removed request for mstmdev July 15, 2024 10:04
@mstmdev mstmdev added this to the v0.9.0 milestone Jul 15, 2024
@mstmdev mstmdev force-pushed the main branch 2 times, most recently from 433909c to 419fb4f Compare July 16, 2024 07:08
@mstmdev
Copy link
Member

mstmdev commented Jul 16, 2024

Tests passed. Please check for any issues with this implementation. @wayhoww

@wayhoww
Copy link
Contributor Author

wayhoww commented Jul 16, 2024

left two comments

@mstmdev mstmdev merged commit 3e51b80 into no-src:main Jul 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants