Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables #10

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Add variables #10

merged 7 commits into from
Jul 14, 2022

Conversation

angehung5
Copy link
Collaborator

  1. input_variables.txt is updated by adding surface roughness length (Z0) and changing to southeast domain
  2. domain settings (nlat, nlon) and reading section in canopy_driver.f90 are changed for the updated list

angehung5 and others added 5 commits July 12, 2022 15:18
add surface roughness length (Z0)
domain: 30-40N, 80-100W
change the section of reading input variables
@drnimbusrain
Copy link
Member

@angehung5 This looks good, and I am close to merging with develop, but why are the Monin-Obukhov Lengths (MOL) always zero in the new input_variables.txt file?

Copy link
Member

@drnimbusrain drnimbusrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angehung5 Please update MOL to have values other than zero.

canopy_driver.F90 Show resolved Hide resolved
@angehung5
Copy link
Collaborator Author

File updated. Do I need to pull a request again or you can see the change?

@zmoon
Copy link
Member

zmoon commented Jul 12, 2022

File updated. Do I need to pull a request again or you can see the change?

We see it. Changes you make in the branch associated with the pull request automatically show up here.

@zmoon zmoon mentioned this pull request Jul 12, 2022
Copy link
Member

@drnimbusrain drnimbusrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angehung5 Any idea why the magnitude of values for MOL are so low (typically range from +/- 1 to 200 m)?

@zmoon
Copy link
Member

zmoon commented Jul 13, 2022

That is consistent with the Stull figure for "typical" conditions

image

@angehung5
Copy link
Collaborator Author

OK, I found the problem. I made a mistake in the heat capacity of air. Now the MOL values should be more reasonable.

@drnimbusrain drnimbusrain merged commit 952e619 into noaa-oar-arl:develop Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants