Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed midflameheight to use ceiling instead (test OK). #35

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

drnimbusrain
Copy link
Member

No description provided.

@zmoon
Copy link
Member

zmoon commented Nov 10, 2022

does this imply the top flamelay could be only partial?

@drnimbusrain
Copy link
Member Author

@zmoon Can you further clarify? I just wanted to move it to the upper layer if there is a partial flamelays. Maybe the 2nd ceiling isn't necessary?

@drnimbusrain
Copy link
Member Author

@zmoon FYI. Wei-Ting just tested this new formulation, and the WAF results are looking really good against the Massman example figures in his paper.

@zmoon
Copy link
Member

zmoon commented Nov 11, 2022

I thought that originally you wanted to ensure that flamelays were all full-flame layers. But with flamelays = ceiling(FLAMEH/MODRES) + 1 the top one could be only partial flame.

Seems like another situation where it would be useful to be able to differentiate between interface and "mass" levels.

@drnimbusrain
Copy link
Member Author

@zmoon Ah, yes I see what you are saying considering my previous thoughts. You are right, and I changed to

flamelays = floor(FLAMEH/MODRES) + 1
MIDFLAMEPOINT = max(ceiling(flamelays/2.0),2)

I change in latest commit, and this formulation seems to give best answer for midflameheight and layer.

@drnimbusrain
Copy link
Member Author

@zmoon Can we now merge this with Main? Thanks!

@drnimbusrain drnimbusrain merged commit ada7588 into main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants