Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python runner #54

Merged
merged 37 commits into from
Apr 12, 2023
Merged

Python runner #54

merged 37 commits into from
Apr 12, 2023

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Apr 10, 2023

Python module to run canopy-app and autoload output with xarray.

Will help with #24

todo:

  • validate config (at least keys)
  • sensitivity helper (namelist options)
  • able to run the point case
  • verbose
  • readme for python dir
  • Binder config (maybe for separate PR, with notebook examples including plotting and such)

@drnimbusrain
Copy link
Member

@zmoon These look like great features! Looking forward to updated README with examples for running the python dir. Do we want to add simple py plotting/analysis to this as well? Are you envisioning this to run automatically with new commits/PRs?

Thank you!

@zmoon
Copy link
Member Author

zmoon commented Apr 11, 2023

examples for running the python dir

You can try it out right now if you want, e.g.

cd python
ipython -i run.py
ds.<something>
...

Are you envisioning this to run automatically with new commits/PRs?

Yes but also for us to use.

Do we want to add simple py plotting/analysis to this as well?

Yeah I will set up some notebook examples.

@zmoon zmoon force-pushed the py branch 4 times, most recently from f1e5699 to fdfc28f Compare April 11, 2023 22:33
@zmoon zmoon marked this pull request as ready for review April 11, 2023 22:37
@zmoon zmoon requested a review from drnimbusrain April 11, 2023 22:37
@zmoon
Copy link
Member Author

zmoon commented Apr 12, 2023

Maybe should add a reference to the Python readme in the main readme.

@drnimbusrain
Copy link
Member

@zmoon Yes, I would add some description/reference in the main README. Other than that, I tested and I really like this start to python functionality!

@drnimbusrain drnimbusrain merged commit adcc1b6 into develop Apr 12, 2023
@drnimbusrain drnimbusrain deleted the py branch April 12, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants