Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python examples #58

Merged
merged 29 commits into from
Apr 25, 2023
Merged

Python examples #58

merged 29 commits into from
Apr 25, 2023

Conversation

zmoon
Copy link
Member

@zmoon zmoon commented Apr 13, 2023

todo:

  • interactive var sel on the other 2-D case sets
  • refactor in some places a bit to reduce code duplication
    • made fn for interactive var sel
  • Binder config
  • run notebook(s) in CI
  • fix output var name/units consistency between text and nc outputs?
  • remove the Patrick notes from notebook

@drnimbusrain
Copy link
Member

@zmoon Thank you so much for doing all of this! Understood that you should very soon turn your attention to UFS/NEXUS, but if we wrap this up it would be helpful! Thanks again.

@zmoon
Copy link
Member Author

zmoon commented Apr 17, 2023

Looks like running the example nb currently takes ~ 50 s in CI. Not bad, but will later (probably not in this PR) add parallel sensitivity run option which will help with this.

@zmoon
Copy link
Member Author

zmoon commented Apr 17, 2023

Binder test link:

https://mybinder.org/v2/gh/noaa-oar-arl/canopy-app/py-examples?labpath=python%2Fexamples.ipynb

since on Binder it gets `jovyan` instead of `canopy-app`
@drnimbusrain
Copy link
Member

@zmoon Thank you for continuing to work and wrap up these great Python examples and binder for the tests...I think it will be a great way for us to test canopy-app more effectively!

@zmoon
Copy link
Member Author

zmoon commented Apr 24, 2023

@drnimbusrain how do we want to address the var differences?

The bio emi ones are the same, the differences are:

nc txt
canwind ws
flameh flame_height
- canopy_height

Note that canopy height isn't in the nc output but is in the txt output.

The txt names are formed in the Python by taking those in the text output header and lowercasing and replacing with _.

@drnimbusrain
Copy link
Member

@zmoon This is a great point on the inconsistent variables. I will add "canheight" to the NC output and change the txt output variable names to be consistent.

@zmoon
Copy link
Member Author

zmoon commented Apr 25, 2023

I will add "canheight" to the NC output and change the txt output variable names to be consistent.

Ok, do you want to do it in this PR?

Or let me attempt and then you can review?

@drnimbusrain
Copy link
Member

@zmoon great to do it on this PR, and would appreciate if you could attempt then...

@zmoon zmoon marked this pull request as ready for review April 25, 2023 15:29
@zmoon zmoon requested a review from drnimbusrain April 25, 2023 15:30
@zmoon
Copy link
Member Author

zmoon commented Apr 25, 2023

@drnimbusrain I'll remove your notes from the nb after you review, want to leave them for now so you have them.

@zmoon
Copy link
Member Author

zmoon commented Apr 25, 2023

I know I already changed it to canwind, but in retrospect maybe ws is better since WS above the canopy is included too, yes? Also fine with canwind though.

@drnimbusrain
Copy link
Member

drnimbusrain commented Apr 25, 2023 via email

@drnimbusrain
Copy link
Member

@zmoon I think this looks great! You can remove my notes and merge.

kept the ones explaining some of the options, but moved to
within the code
@zmoon zmoon merged commit b177362 into develop Apr 25, 2023
@zmoon zmoon deleted the py-examples branch April 25, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants