Modified Makefile to work with both ifort or gfortran to build canopy-app (Tested on Hera for ifort) #75

quaz115 · 2023-06-09T01:22:37Z

#FCFLAGS := -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 #Equivalent to gfortran Debug flags, builds with warnings on Hera
FCFLAGS := -g -warn all -check bounds -traceback #builds without warnings on Hera

-stand flag works for different Fortran version (say for Fortran 2008, f90 can be replaced by f08)
Optimization flag can also be changed accordingly (-O1, -O2 etc.)

…-app

src/Makefile

zmoon

Thanks @quaz115 , just added a few initial comments.

src/Makefile

zmoon · 2023-06-09T01:55:02Z

src/Makefile


 # Compiler
 FC ?= gfortran
 ifeq ($(FC), f77)  # override possible Make default
+  FC := ifort 


We could continue to have gfortran here I would think, but @drnimbusrain can decide.

Yes, lets leave gfortran here. Please revert changes.

zmoon · 2023-06-09T01:55:38Z

src/Makefile

+  ifeq ($(FC),gfortran)
+    FCFLAGS := -g -Wall -Wextra -Wconversion -Og -pedantic -fcheck=bounds -fmax-errors=5 
+  else ifeq ($(FC),ifort)
+    #FCFLAGS := -g -warn all -implicitnone -O1 -stand f90 -error-limit 5  #Equivalent to gfortran Debug flags, builds with warnings on Hera


Can we address those warnings as part of this PR?

Agreed, @quaz115 what are the warnings using ifort on Hera with those FCFLAGS?

These are the warnings (in the next comment):

DEBUG=1 NETCDF=1 FC=ifort make -C src

where, DEBUG = -g -warn all -implicitnone -O1 -stand f90 -error-limit 5

DEBUG=1 NETCDF=1 FC=ifort make -C src FC setting: 'ifort' DEBUG setting: '1' NETCDF setting: '1' LIBS: ' -L/apps/netcdf/4.6.1/intel/16.1.150/lib -lnetcdff -L/apps/netcdf/4.6.1/intel/16.1.150/lib -Wl,-rpath -Wl,/apps/netcdf/4.6.1/intel/16.1.150/lib -lnetcdf -lnetcdf' INC: ' -I/apps/netcdf/4.6.1/intel/16.1.150/include' make: Entering directory `/scratch1/BMC/rcm2/qrasool/canopy-app/src' ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_const_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_coord_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_canopts_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_canmet_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_canvars_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_utils_mod.F90 canopy_utils_mod.F90(20): warning #8144: ASSOCIATE construct is not available in Fortran 90. associate(n => size(x)) --------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_files_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_readnml.F90 canopy_readnml.F90(56): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL EXIT(istat) -------------^ canopy_readnml.F90(212): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL EXIT(istat) -------------^ canopy_readnml.F90(219): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL EXIT(istat) -------------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_alloc.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_init.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_txt_io_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_ncf_io_mod.F90 canopy_ncf_io_mod.F90(2051): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%lat=reshape(variables_2d%lat,[size(variables_2d%lat)]) ---------------------------------------------------^ canopy_ncf_io_mod.F90(2059): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%lon=reshape(variables_2d%lon,[size(variables_2d%lon)]) ---------------------------------------------------^ canopy_ncf_io_mod.F90(2069): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%clu=reshape(variables_2d%clu,[size(variables_2d%clu)]) ---------------------------------------------------^ canopy_ncf_io_mod.F90(2078): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%csz=reshape(variables_2d%csz,[size(variables_2d%csz)]) ---------------------------------------------------^ canopy_ncf_io_mod.F90(2087): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%ffrac=reshape(variables_2d%ffrac,[size(variables_2d%ffrac)]) -------------------------------------------------------^ canopy_ncf_io_mod.F90(2096): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%fh=reshape(variables_2d%fh,[size(variables_2d%fh)]) -------------------------------------------------^ canopy_ncf_io_mod.F90(2105): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%frp=reshape(variables_2d%frp,[size(variables_2d%frp)]) ---------------------------------------------------^ canopy_ncf_io_mod.F90(2114): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%href=reshape(variables_2d%href,[size(variables_2d%href)]) -----------------------------------------------------^ canopy_ncf_io_mod.F90(2123): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%lai=reshape(variables_2d%lai,[size(variables_2d%lai)]) ---------------------------------------------------^ canopy_ncf_io_mod.F90(2132): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%mol=reshape(variables_2d%mol,[size(variables_2d%mol)]) ---------------------------------------------------^ canopy_ncf_io_mod.F90(2141): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%fricv=reshape(variables_2d%fricv,[size(variables_2d%fricv)]) -------------------------------------------------------^ canopy_ncf_io_mod.F90(2150): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%ugrd10m=reshape(variables_2d%ugrd10m,[size(variables_2d%ugrd10m)]) -----------------------------------------------------------^ canopy_ncf_io_mod.F90(2159): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%vgrd10m=reshape(variables_2d%vgrd10m,[size(variables_2d%vgrd10m)]) -----------------------------------------------------------^ canopy_ncf_io_mod.F90(2168): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%sfcr=reshape(variables_2d%sfcr,[size(variables_2d%sfcr)]) -----------------------------------------------------^ canopy_ncf_io_mod.F90(2177): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%vtype=reshape(variables_2d%vtype,[size(variables_2d%vtype)]) -------------------------------------------------------^ canopy_ncf_io_mod.F90(2186): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%sotyp=reshape(variables_2d%sotyp,[size(variables_2d%sotyp)]) -------------------------------------------------------^ canopy_ncf_io_mod.F90(2195): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%pressfc=reshape(variables_2d%pressfc,[size(variables_2d%pressfc)]) -----------------------------------------------------------^ canopy_ncf_io_mod.F90(2204): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%dswrf=reshape(variables_2d%dswrf,[size(variables_2d%dswrf)]) -------------------------------------------------------^ canopy_ncf_io_mod.F90(2213): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%shtfl=reshape(variables_2d%shtfl,[size(variables_2d%shtfl)]) -------------------------------------------------------^ canopy_ncf_io_mod.F90(2222): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%tmpsfc=reshape(variables_2d%tmpsfc,[size(variables_2d%tmpsfc)]) ---------------------------------------------------------^ canopy_ncf_io_mod.F90(2231): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%tmp2m=reshape(variables_2d%tmp2m,[size(variables_2d%tmp2m)]) -------------------------------------------------------^ canopy_ncf_io_mod.F90(2240): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%spfh2m=reshape(variables_2d%spfh2m,[size(variables_2d%spfh2m)]) ---------------------------------------------------------^ canopy_ncf_io_mod.F90(2249): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%hpbl=reshape(variables_2d%hpbl,[size(variables_2d%hpbl)]) -----------------------------------------------------^ canopy_ncf_io_mod.F90(2258): warning #5197: Fortran 90 does not allow array constructors in square brackets variables%prate_ave=reshape(variables_2d%prate_ave,[size(variables_2d%prate_ave)]) ---------------------------------------------------------------^ canopy_ncf_io_mod.F90(943): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -----------------^ canopy_ncf_io_mod.F90(951): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -----------------^ canopy_ncf_io_mod.F90(959): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -----------------^ canopy_ncf_io_mod.F90(982): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -----------------^ canopy_ncf_io_mod.F90(990): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -----------------^ canopy_ncf_io_mod.F90(998): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -----------------^ canopy_ncf_io_mod.F90(1526): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(1538): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(1546): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(1554): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(1562): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(1570): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(1588): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) -------------------------^ canopy_ncf_io_mod.F90(1605): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) -------------------------^ canopy_ncf_io_mod.F90(1622): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) -------------------------^ canopy_ncf_io_mod.F90(1639): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) -------------------------^ canopy_ncf_io_mod.F90(1665): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1671): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1688): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1694): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1711): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1718): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1725): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1742): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1749): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1756): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1768): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) ---------------------^ canopy_ncf_io_mod.F90(1850): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1869): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1891): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1913): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) -------------------------^ canopy_ncf_io_mod.F90(1926): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit (2) ---------------------^ canopy_ncf_io_mod.F90(2008): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------^ canopy_ncf_io_mod.F90(2019): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) -----------------^ canopy_ncf_io_mod.F90(2026): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) -----------------^ canopy_ncf_io_mod.F90(2036): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) -----------------^ canopy_ncf_io_mod.F90(2048): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2056): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2066): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2075): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2084): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2093): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2102): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2111): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2120): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2129): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2138): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2147): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2156): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2165): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2174): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2183): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2192): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2201): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2210): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2219): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2228): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2237): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2246): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2255): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2266): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2273): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2282): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2289): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2296): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2303): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2310): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2317): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2324): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2331): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2338): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2345): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2352): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2359): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2366): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2373): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2380): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2387): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2394): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2401): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2408): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2415): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2422): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2429): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] CALL exit(2) ---------------------^ canopy_ncf_io_mod.F90(2433): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_check_input.F90 canopy_check_input.F90(31): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_read_txt.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_dxcalc_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_profile_mod.F90 canopy_profile_mod.F90(67): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------------------^ canopy_profile_mod.F90(90): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------------------^ canopy_profile_mod.F90(113): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------------------^ canopy_profile_mod.F90(136): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------------------^ canopy_profile_mod.F90(145): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------^ canopy_profile_mod.F90(305): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) ---------------------^ canopy_profile_mod.F90(309): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_wind_mod.F90 canopy_wind_mod.F90(79): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(1) -----------------^ canopy_wind_mod.F90(96): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(1) -----------------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_waf_mod.F90 canopy_waf_mod.F90(68): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) ---------------------^ canopy_waf_mod.F90(78): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------------------^ canopy_waf_mod.F90(93): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------------------^ canopy_waf_mod.F90(98): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_phot_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_eddy_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_bioparm_mod.F90 canopy_bioparm_mod.F90(797): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_bioemi_mod.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_calcs.F90 canopy_calcs.F90(45): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------^ canopy_calcs.F90(119): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------------------------------^ canopy_calcs.F90(239): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------------------^ canopy_calcs.F90(260): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -----------------^ canopy_calcs.F90(331): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------------------------------^ canopy_calcs.F90(451): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) ---------------------^ canopy_calcs.F90(458): warning #7416: Fortran 90 does not allow this intrinsic procedure. [EXIT] call exit(2) -------------^ ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_write_txt.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_dealloc.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF -I/apps/netcdf/4.6.1/intel/16.1.150/include -c canopy_app.F90 ifort -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 -DNETCDF canopy_const_mod.o canopy_coord_mod.o canopy_canopts_mod.o canopy_canmet_mod.o canopy_canvars_mod.o canopy_utils_mod.o canopy_files_mod.o canopy_readnml.o canopy_alloc.o canopy_init.o canopy_txt_io_mod.o canopy_ncf_io_mod.o canopy_check_input.o canopy_read_txt.o canopy_dxcalc_mod.o canopy_profile_mod.o canopy_wind_mod.o canopy_waf_mod.o canopy_phot_mod.o canopy_eddy_mod.o canopy_bioparm_mod.o canopy_bioemi_mod.o canopy_calcs.o canopy_write_txt.o canopy_dealloc.o canopy_app.o -o ../canopy -L/apps/netcdf/4.6.1/intel/16.1.150/lib -lnetcdff -L/apps/netcdf/4.6.1/intel/16.1.150/lib -Wl,-rpath -Wl,/apps/netcdf/4.6.1/intel/16.1.150/lib -lnetcdf -lnetcdf -I/apps/netcdf/4.6.1/intel/16.1.150/include make: Leaving directory `/scratch1/BMC/rcm2/qrasool/canopy-app/src'

Co-authored-by: Zachary Moon <[email protected]>

drnimbusrain · 2023-06-09T02:30:26Z

src/Makefile


 # Compiler
 FC ?= gfortran
 ifeq ($(FC), f77)  # override possible Make default
+  FC := ifort 


Yes, lets leave gfortran here. Please revert changes.

src/Makefile

drnimbusrain · 2023-06-09T02:34:10Z

src/Makefile

+  ifeq ($(FC),gfortran)
+    FCFLAGS := -g -Wall -Wextra -Wconversion -Og -pedantic -fcheck=bounds -fmax-errors=5 
+  else ifeq ($(FC),ifort)
+    #FCFLAGS := -g -warn all -implicitnone -O1 -stand f90 -error-limit 5  #Equivalent to gfortran Debug flags, builds with warnings on Hera


Agreed, @quaz115 what are the warnings using ifort on Hera with those FCFLAGS?

drnimbusrain · 2023-06-09T02:41:43Z

@quaz115 Thanks for the PR! I do agree with Zach's comments and we should not make most of these changes though, except for the additional ifort debug flags starting at line 27. The Makefile has already been made to accept whatever FC chosen, with default being gfortran if not specified. So, this should be OK. @zmoon Can we revert those changes?

However, please lets also address the "builds with warnings on Hera" flags for ifort in this PR, as we should determine what in canopy-app is causing this. Thanks for the testing!

…ag options work without warning

drnimbusrain · 2023-06-09T03:50:06Z

Quazi, The FC=ifort can be argument given when compiling. gfortran should be left as the default, and that command is just an override.

…

On Thu, Jun 8, 2023, 10:57 PM quaz115 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/Makefile <#75 (comment)> : > # Compiler FC ?= gfortran ifeq ($(FC), f77) # override possible Make default + FC := ifort @zmoon <https://github.com/zmoon> @drnimbusrain <https://github.com/drnimbusrain> , i think we need this change, When i revert back, FC shows as gfortran and i get build error: Fatal Error: File 'netcdf.mod' opened at (1) is not a GNU Fortran module file make: *** [canopy_ncf_io_mod.o] Error 1 I think we need these changes (or FC to be assigned ifort somewhere) — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLFYNWE4MLNESZHLHLL53TXKKGKNANCNFSM6AAAAAAY77ZZUM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

quaz115 · 2023-06-09T04:08:52Z

Quazi, The FC=ifort can be argument given when compiling. gfortran should be left as the default, and that command is just an override.
…
On Thu, Jun 8, 2023, 10:57 PM quaz115 @.> wrote: @.* commented on this pull request. ------------------------------ In src/Makefile <#75 (comment)> : > # Compiler FC ?= gfortran ifeq ($(FC), f77) # override possible Make default + FC := ifort @zmoon https://github.com/zmoon @drnimbusrain https://github.com/drnimbusrain , i think we need this change, When i revert back, FC shows as gfortran and i get build error: Fatal Error: File 'netcdf.mod' opened at (1) is not a GNU Fortran module file make: *** [canopy_ncf_io_mod.o] Error 1 I think we need these changes (or FC to be assigned ifort somewhere) — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLFYNWE4MLNESZHLHLL53TXKKGKNANCNFSM6AAAAAAY77ZZUM . You are receiving this because you were mentioned.Message ID: @.***>

Agreed

drnimbusrain · 2023-06-09T11:29:12Z

@quaz115 Thanks for checking with the FC=ifort appropriately. Seems like only changes needed then are for your additions to the ifort FC flags. The gfortran equivalent flags are having the warning:
#FCFLAGS := -g -warn all -implicitnone -O1 -stand f90 -error-limit 5 #Equivalent to gfortran Debug flags #builds but with WARNINGS to be resolved

Seems like its mainly the ifort f90 standards (-stand f90) having issues with the following in canopy-app:

ASSOCIATE construct is not available in Fortran 90. (e.g., associate(n => size(x)))
Fortran 90 does not allow this intrinsic procedure. [EXIT] (e.g., CALL EXIT(istat))
Fortran 90 does not allow array constructors in square brackets. (e.g., [size(variables_2d%mol)])
Fortran 90 does not allow this intrinsic procedure. [EXIT] (e.g., call exit(2))

@zmoon Am I missing anything? We should likely fix these up for ifort.

drnimbusrain · 2023-06-09T11:31:17Z

@quaz115 Also, can you include the development practices described in the README under

This should fix the Lint formatting issues with your PR. Thanks!

quaz115 · 2023-06-09T15:08:50Z

@quaz115 Also, can you include the development practices described in the README under

This should fix the Lint formatting issues with your PR. Thanks!

@zmoon if i follow the above steps on my local develop branch fork , would it fix the lint formatting issue on this PR or i need to re-commit the Makefile changes again and create a new PR?

zmoon · 2023-06-09T15:39:05Z

@quaz115 after you install the pre-commit hooks you can just do pre-commit run --all-files and commit the result of that to please the formatter. That can be in your develop branch (this PR).

zmoon · 2023-06-09T15:40:47Z

We need to use a higher standard, e.g. 2003 (for associate), but enable the compiler extensions in order to use the exit subroutine (which is not part of the Fortran standard, but is included in both GNU and Intel's extensions).

For GFortran, if desired, we can achieve this with -std=f2003 -fall-intrinsics.

For Intel I can't find how to do that so we can just not use -stand.

bbakernoaa · 2023-06-09T15:53:02Z

we should probably think in a future PR to move to CMake. This will likely be a requirement for integration into CATChem later on.

drnimbusrain · 2023-06-09T16:00:07Z

Thanks Barry, yes that is already an issue to move to CMake.

…

On Fri, Jun 9, 2023, 11:53 AM Barry Baker ***@***.***> wrote: we should probably think in a future PR to move to CMake. This will likely be a requirement for integration into CATChem later on. — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLFYNR7JXZP3JGL527YKH3XKNBGVANCNFSM6AAAAAAY77ZZUM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

drnimbusrain · 2023-06-09T17:38:54Z

@quaz115 Do you mind making Zach's suggestions and test compiling the DEBUG mode flags for both gfortran and ifort compilers and make the commits here? We just need to have one for each and make sure no warnings are thrown.

We need to use a higher standard, e.g. 2003 (for associate), but enable the compiler extensions in order to use the exit subroutine (which is not part of the Fortran standard, but is included in both GNU and Intel's extensions).

For GFortran we can achieve this with -std=f2003 -fall-intrinsics.

For Intel I can't find how to do that so we can just not use -stand. (Maybe you can figure out how to do it for Intel)

zmoon · 2023-06-09T17:43:58Z

For Intel I can't find how to do that so we can just not use -stand. (Maybe you can figure out how to do it for Intel)

FWIW, seems like they don't use -stand with FV3.

zmoon · 2023-06-09T17:47:14Z

We can include ifort in the CI tests¹ with setup-fortran. But I can do that in a separate PR, unless @quaz115 you want to do it here.

probably just non-netCDF build initially ↩

drnimbusrain · 2023-06-09T18:16:13Z

For Intel I can't find how to do that so we can just not use -stand. (Maybe you can figure out how to do it for Intel)

FWIW, seems like they don't use -stand with FV3.

OK Zach, lets just remove -stand from the ifort DEBUG flags, and test your suggestion for gfortran: -std=f2003 -fall-intrinsics

@quaz115 Can you test these in your branch and commit if both ifort and gfortran compile OK with no warnings.

quaz115 · 2023-06-09T18:16:57Z

@quaz115 after you install the pre-commit hooks you can just do pre-commit run --all-files and commit the result of that to please the formatter. That can be in your develop branch (this PR).

@zmoon i am getting following issue when i try to install the pre-commit hooks:

pre-commit --version
pre-commit 3.3.2
(base) |12:11:52|Quazi.Rasool@hfe08:[canopy-app-forkqzr]> pre-commit install --install-hooks
pre-commit installed at .git/hooks/pre-commit
[INFO] Installing environment for https://github.com/kynan/nbstripout.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: CalledProcessError: command: ('/home/Quazi.Rasool/.cache/pre-commit/repo4ydrc5pt/py_env-python3.10/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
Processing /home/Quazi.Rasool/.cache/pre-commit/repo4ydrc5pt
Preparing metadata (setup.py): started
Preparing metadata (setup.py): finished with status 'done'
Collecting nbformat (from nbstripout==0.6.1)
stderr:
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f2b7dddfe80>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/e1/ce/7f0f454b4e7f1cb31345f9f977bdce7486033a1c08b5945b17ea95c4afbc/nbformat-5.9.0-py3-none-any.whl
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f2b7dddfd90>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/e1/ce/7f0f454b4e7f1cb31345f9f977bdce7486033a1c08b5945b17ea95c4afbc/nbformat-5.9.0-py3-none-any.whl
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f2b7dddd330>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/e1/ce/7f0f454b4e7f1cb31345f9f977bdce7486033a1c08b5945b17ea95c4afbc/nbformat-5.9.0-py3-none-any.whl
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f2b7dddf880>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/e1/ce/7f0f454b4e7f1cb31345f9f977bdce7486033a1c08b5945b17ea95c4afbc/nbformat-5.9.0-py3-none-any.whl
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f2b7ddddba0>: Failed to establish a new connection: [Errno 101] Network is unreachable')': /packages/e1/ce/7f0f454b4e7f1cb31345f9f977bdce7486033a1c08b5945b17ea95c4afbc/nbformat-5.9.0-py3-none-any.whl
ERROR: Could not install packages due to an OSError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Max retries exceeded with url: /packages/e1/ce/7f0f454b4e7f1cb31345f9f977bdce7486033a1c08b5945b17ea95c4afbc/nbformat-5.9.0-py3-none-any.whl (Caused by NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object at 0x7f2b7dddec80>: Failed to establish a new connection: [Errno 101] Network is unreachable'))
Check the log at /home/Quazi.Rasool/.cache/pre-commit/pre-commit.log

quaz115 · 2023-06-09T19:57:03Z

Thanks Zach, should have done a module purge. Great! Seems just the NETCDF to NC change is needed and the ifort CI check for this right?
…
On Fri, Jun 9, 2023, 2:58 PM Zachary Moon @.> wrote: getting H5 errors with gfortran testing @drnimbusrain https://github.com/drnimbusrain I think you have other modules loaded. With just Currently Loaded Modules: 1) gnu/9.2.0 2) netcdf/4.7.2 I don't get any errors/warnings. — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLFYNQ6CKYTKABUL2WCTA3XKNW65ANCNFSM6AAAAAAY77ZZUM . You are receiving this because you were mentioned.Message ID: @.>

@zmoon Should NETCDF_FLIBS and NETCDF_INC also be edited to NC_FLIBS and NC_INC? and what about: FCFLAGS += -DNETCDF

drnimbusrain · 2023-06-09T20:19:04Z

No, I don't think so.

…

On Fri, Jun 9, 2023, 3:57 PM quaz115 ***@***.***> wrote: Thanks Zach, should have done a module purge. Great! Seems just the NETCDF to NC change is needed and the ifort CI check for this right? … <#m_-1963340890694455230_> On Fri, Jun 9, 2023, 2:58 PM Zachary Moon *@*.*> wrote: getting H5 errors with gfortran testing @drnimbusrain <https://github.com/drnimbusrain> https://github.com/drnimbusrain <https://github.com/drnimbusrain> I think you have other modules loaded. With just Currently Loaded Modules: 1) gnu/9.2.0 2) netcdf/4.7.2 I don't get any errors/warnings. — Reply to this email directly, view it on GitHub <#75 (comment) <#75 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLFYNQ6CKYTKABUL2WCTA3XKNW65ANCNFSM6AAAAAAY77ZZUM <https://github.com/notifications/unsubscribe-auth/AGLFYNQ6CKYTKABUL2WCTA3XKNW65ANCNFSM6AAAAAAY77ZZUM> . You are receiving this because you were mentioned.Message ID: @.*> Should NETCDF_FLIBS and NETCDF_INC also be edited to NC_FLIBS and NC_INC? — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLFYNQH6QMDGHAHSW35XETXKN5ZVANCNFSM6AAAAAAY77ZZUM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

…error/warning)

quaz115 · 2023-06-09T20:20:22Z

ok, just added the latest commit (tested already) On Fri, Jun 9, 2023 at 1:19 PM Patrick Campbell ***@***.***> wrote:

…

No, I don't think so. On Fri, Jun 9, 2023, 3:57 PM quaz115 ***@***.***> wrote: > Thanks Zach, should have done a module purge. Great! Seems just the NETCDF > to NC change is needed and the ifort CI check for this right? > … <#m_-1963340890694455230_> > On Fri, Jun 9, 2023, 2:58 PM Zachary Moon *@*.*> wrote: getting H5 errors > with gfortran testing @drnimbusrain <https://github.com/drnimbusrain> > https://github.com/drnimbusrain <https://github.com/drnimbusrain> I think > you have other modules loaded. With just Currently Loaded Modules: 1) > gnu/9.2.0 2) netcdf/4.7.2 I don't get any errors/warnings. — Reply to this > email directly, view it on GitHub <#75 (comment) > < #75 (comment)>>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AGLFYNQ6CKYTKABUL2WCTA3XKNW65ANCNFSM6AAAAAAY77ZZUM > < https://github.com/notifications/unsubscribe-auth/AGLFYNQ6CKYTKABUL2WCTA3XKNW65ANCNFSM6AAAAAAY77ZZUM> > . You are receiving this because you were mentioned.Message ID: @.*> > > Should NETCDF_FLIBS and NETCDF_INC also be edited to NC_FLIBS and NC_INC? > > — > Reply to this email directly, view it on GitHub > < #75 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AGLFYNQH6QMDGHAHSW35XETXKN5ZVANCNFSM6AAAAAAY77ZZUM> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APFNFOKBLXGT3SS4ZUNLMW3XKOAMHANCNFSM6AAAAAAY77ZZUM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

zmoon

Also need to update readme (Getting Started / Build).

src/Makefile

Co-authored-by: Zachary Moon <[email protected]>

drnimbusrain · 2023-06-10T01:20:30Z

Thanks Quazi and Zach, both options working well for me now too. Just updates to README for the build ifort option and change to 'NC' setting and maybe the CI ifort check if Zach has time.

Maybe something like this Quazi?

Compilation options can be controlled with environment variables:

FC=gfortran (default) or ifort
DEBUG=0 (off; default) or DEBUG=1 (on)
NC=0 (off) or NC=1 (on; default)
Example:

DEBUG=1 NC=1 make -C src

quaz115 · 2023-06-10T04:22:11Z

Thanks Quazi and Zach, both options working well for me now too. Just updates to README for the build ifort option and change to 'NC' setting and maybe the CI ifort check if Zach has time.

Maybe something like this Quazi?
Compilation options can be controlled with environment variables:

FC=gfortran (default) or ifort
DEBUG=0 (off; default) or DEBUG=1 (on)
NC=0 (off) or NC=1 (on; default)
Example:

DEBUG=1 NC=1 make -C src

Just suggesting minor addition for more clarity i think:

Compilation options can be controlled with environment variables:

FC=gfortran (default) or ifort
DEBUG=0 (off; default) or DEBUG=1 (on)
NC=0 (off) or NC=1 (on; default)

Example:
a) with gfortran, Debug flags ON and with Netcdf:
       DEBUG=1 NC=1 make -C src         
b) with ifort, Debug flags ON and with Netcdf:      
       DEBUG=1 NC=1 FC=ifort make -C src

zmoon · 2023-06-10T13:50:43Z

a) with gfortran, Debug flags ON and with Netcdf:
DEBUG=1 NC=1 make -C src

We may want to note that not supplying FC in your line doesn't necessary give gfortran, since FC might already be set in the environment (seems some module load situations do this).

drnimbusrain · 2023-06-10T15:15:55Z

Good idea Zach. Go ahead and make the README changes Quazi. Thanks!

…

On Sat, Jun 10, 2023, 9:50 AM Zachary Moon ***@***.***> wrote: a) with gfortran, Debug flags ON and with Netcdf: DEBUG=1 NC=1 make -C src We may want to note that not supplying FC in your line doesn't necessary give gfortran, since FC might already be set in the environment (seems some module load situations do this). — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGLFYNUSEWDN4YIIUF24US3XKR3T3ANCNFSM6AAAAAAY77ZZUM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

… and ifort

quaz115 · 2023-06-10T22:30:56Z

a) with gfortran, Debug flags ON and with Netcdf:
DEBUG=1 NC=1 make -C src

We may want to note that not supplying FC in your line doesn't necessary give gfortran, since FC might already be set in the environment (seems some module load situations do this).

Incorporated in README.md changes

quaz115 · 2023-06-10T22:31:08Z

Good idea Zach. Go ahead and make the README changes Quazi. Thanks!
…
On Sat, Jun 10, 2023, 9:50 AM Zachary Moon @.> wrote: a) with gfortran, Debug flags ON and with Netcdf: DEBUG=1 NC=1 make -C src We may want to note that not supplying FC in your line doesn't necessary give gfortran, since FC might already be set in the environment (seems some module load situations do this). — Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLFYNUSEWDN4YIIUF24US3XKR3T3ANCNFSM6AAAAAAY77ZZUM . You are receiving this because you were mentioned.Message ID: @.>

Done!

…Makefile to build Canopy-app with both ifort and gfortran

drnimbusrain · 2023-06-11T21:22:24Z

@zmoon are we ready to merge?

drnimbusrain · 2023-06-12T13:19:48Z

@zmoon Did you want to add the CI changes, or merge now?

zmoon

@drnimbusrain I will add to the CI in separate PR, since I will probably have to experiment a bit. Also I may add more debug flags.

README.md

src/Makefile

Co-authored-by: Zachary Moon <[email protected]>

drnimbusrain · 2023-06-12T22:53:00Z

OK, thank you Quazi and Zach for these updates!

Modified Makefile to work with both ifort or gfortran to build canopy…

49f0110

…-app

quaz115 requested review from bbakernoaa, drnimbusrain and zmoon June 9, 2023 01:23

zmoon reviewed Jun 9, 2023

View reviewed changes

src/Makefile Outdated Show resolved Hide resolved

zmoon reviewed Jun 9, 2023

View reviewed changes

drnimbusrain removed the request for review from bbakernoaa June 9, 2023 02:24

Update src/Makefile

55ba56d

Co-authored-by: Zachary Moon <[email protected]>

drnimbusrain requested changes Jun 9, 2023

View reviewed changes

Update Makefile

91b5b43

drnimbusrain requested a review from zmoon June 9, 2023 02:43

quaz115 added 2 commits June 8, 2023 19:59

Update Makefile ifort

cb97f66

Update Makefile- Latest build check with ifort on Hera, both debug fl…

0798252

…ag options work without warning

Update Makefile- Resolved, one debug flag (ifort) gives warning

fd24cb1

zmoon mentioned this pull request Jun 9, 2023

[Build] Adding CMake to Canopy-App #68

Open

Update Makefile- $NETCDF to $NC (ifort builds and make clean without …

b4bf7cf

…error/warning)

zmoon reviewed Jun 9, 2023

View reviewed changes

src/Makefile Outdated Show resolved Hide resolved

src/Makefile Outdated Show resolved Hide resolved

quaz115 and others added 2 commits June 9, 2023 16:17

Update src/Makefile

7a31069

Co-authored-by: Zachary Moon <[email protected]>

Update src/Makefile

b21eba3

Co-authored-by: Zachary Moon <[email protected]>

drnimbusrain added the enhancement New feature or request label Jun 10, 2023

Update README.md- Edited for src/Makefile to build with both gfortran…

facadbd

… and ifort

quaz115 added 2 commits June 10, 2023 15:33

Update README.md (trailing whitespaces removed)

85f51d2

Update README.md- Edited README.md to account for enhancement in src/…

21689fa

…Makefile to build Canopy-app with both ifort and gfortran

drnimbusrain requested review from zmoon and drnimbusrain June 11, 2023 21:22

drnimbusrain approved these changes Jun 12, 2023

View reviewed changes

zmoon reviewed Jun 12, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

src/Makefile Outdated Show resolved Hide resolved

quaz115 and others added 5 commits June 12, 2023 14:31

Update README.md

9136581

Co-authored-by: Zachary Moon <[email protected]>

Update README.md

fe28540

Co-authored-by: Zachary Moon <[email protected]>

Update README.md

51e17ca

Co-authored-by: Zachary Moon <[email protected]>

Update src/Makefile (final revised ifort FCFLAGS)

7d2b56d

Co-authored-by: Zachary Moon <[email protected]>

Update README.md (NETCDF to NC)

cd67163

drnimbusrain merged commit fef67b7 into noaa-oar-arl:develop Jun 12, 2023
4 checks passed

Modified Makefile to work with both ifort or gfortran to build canopy-app (Tested on Hera for ifort) #75

Modified Makefile to work with both ifort or gfortran to build canopy-app (Tested on Hera for ifort) #75

Conversation

quaz115 commented Jun 9, 2023

zmoon left a comment

Choose a reason for hiding this comment

zmoon Jun 9, 2023

Choose a reason for hiding this comment

drnimbusrain Jun 9, 2023 • edited Loading

Choose a reason for hiding this comment

zmoon Jun 9, 2023

Choose a reason for hiding this comment

drnimbusrain Jun 9, 2023 • edited Loading

Choose a reason for hiding this comment

quaz115 Jun 9, 2023 • edited Loading

Choose a reason for hiding this comment

quaz115 Jun 9, 2023 • edited by zmoon Loading

Choose a reason for hiding this comment

drnimbusrain Jun 9, 2023 • edited Loading

Choose a reason for hiding this comment

drnimbusrain Jun 9, 2023 • edited Loading

Choose a reason for hiding this comment

drnimbusrain commented Jun 9, 2023 • edited Loading

drnimbusrain commented Jun 9, 2023 via email

quaz115 commented Jun 9, 2023

drnimbusrain commented Jun 9, 2023

drnimbusrain commented Jun 9, 2023

quaz115 commented Jun 9, 2023

zmoon commented Jun 9, 2023 • edited Loading

zmoon commented Jun 9, 2023 • edited Loading

bbakernoaa commented Jun 9, 2023

drnimbusrain commented Jun 9, 2023 via email

drnimbusrain commented Jun 9, 2023 • edited Loading

zmoon commented Jun 9, 2023 • edited Loading

zmoon commented Jun 9, 2023 • edited Loading

Footnotes

drnimbusrain commented Jun 9, 2023

quaz115 commented Jun 9, 2023 • edited Loading

quaz115 commented Jun 9, 2023 • edited Loading

drnimbusrain commented Jun 9, 2023 via email

quaz115 commented Jun 9, 2023 via email

zmoon left a comment • edited Loading

Choose a reason for hiding this comment

drnimbusrain commented Jun 10, 2023 • edited Loading

quaz115 commented Jun 10, 2023 • edited Loading

zmoon commented Jun 10, 2023

drnimbusrain commented Jun 10, 2023 via email

quaz115 commented Jun 10, 2023

quaz115 commented Jun 10, 2023

drnimbusrain commented Jun 11, 2023

drnimbusrain commented Jun 12, 2023

zmoon left a comment

Choose a reason for hiding this comment

drnimbusrain commented Jun 12, 2023

drnimbusrain Jun 9, 2023 •

edited

Loading

drnimbusrain Jun 9, 2023 •

edited

Loading

quaz115 Jun 9, 2023 •

edited

Loading

quaz115 Jun 9, 2023 •

edited by zmoon

Loading

drnimbusrain Jun 9, 2023 •

edited

Loading

drnimbusrain Jun 9, 2023 •

edited

Loading

drnimbusrain commented Jun 9, 2023 •

edited

Loading

zmoon commented Jun 9, 2023 •

edited

Loading

zmoon commented Jun 9, 2023 •

edited

Loading

drnimbusrain commented Jun 9, 2023 •

edited

Loading

zmoon commented Jun 9, 2023 •

edited

Loading

zmoon commented Jun 9, 2023 •

edited

Loading

quaz115 commented Jun 9, 2023 •

edited

Loading

quaz115 commented Jun 9, 2023 •

edited

Loading

zmoon left a comment •

edited

Loading

drnimbusrain commented Jun 10, 2023 •

edited

Loading

quaz115 commented Jun 10, 2023 •

edited

Loading