Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tleaf ppfd #80

Merged
merged 13 commits into from
Jul 28, 2023
Merged

Tleaf ppfd #80

merged 13 commits into from
Jul 28, 2023

Conversation

drnimbusrain
Copy link
Member

This PR contains commits to restructure the biogenics and removes the parameterization calculations of FSUN, Tleaf, and PPFD. These are now separate modules/subroutines (i.e., canopy_rad_mod.F90, canopy_tleaf_mod.F90, and canopy_ppfd_mod.F90) and calculate necessary variables as inputs to the biogenic module. This facilitates use of these canopy physical profile variables for other canopy-app processes upcoming (e.g., dry deposition), and for including future options for more robust ways in their calculations.

I have checked that these changes do not alter the biogenic emissions calculations:
Previous:
image
New:
image

@drnimbusrain drnimbusrain requested a review from zmoon July 21, 2023 20:21
@drnimbusrain
Copy link
Member Author

@zmoon Can you have a look at this so we can merge?

@quaz115 You can likely use this branch in the meantime for your leaf age developments in biogenics.

Copy link
Member

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With results staying same as you say, I think this is fine.

I think the rad and ppfd mods could be combined into one (probably rad) though.

src/canopy_bioemi_mod.F90 Outdated Show resolved Hide resolved
src/canopy_calcs.F90 Outdated Show resolved Hide resolved
src/canopy_ppfd_mod.F90 Outdated Show resolved Hide resolved
@drnimbusrain
Copy link
Member Author

drnimbusrain commented Jul 28, 2023

With results staying same as you say, I think this is fine.

I think the rad and ppfd mods could be combined into one (probably rad) though.

@zmoon Good suggestion. I have now combined the ppfd mod into rad. Let me know if good to go.

@drnimbusrain drnimbusrain requested a review from zmoon July 28, 2023 14:59
@drnimbusrain drnimbusrain linked an issue Jul 28, 2023 that may be closed by this pull request
@drnimbusrain drnimbusrain merged commit b7d1639 into develop Jul 28, 2023
4 checks passed
@drnimbusrain drnimbusrain deleted the tleaf_ppfd branch July 28, 2023 18:25
@quaz115
Copy link
Collaborator

quaz115 commented Jul 28, 2023

@drnimbusrain Guess can use the latest develop branch now to build upon right?

@drnimbusrain
Copy link
Member Author

drnimbusrain commented Jul 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Stand-Alone Tleaf and PPFD Parametrization Modules
3 participants