Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vegtype dependent FRP to FlameH calculations. #88

Merged
merged 17 commits into from
Sep 29, 2023

Conversation

drnimbusrain
Copy link
Member

This PR address Closes #86 , which stems from Wei-Ting's canopy-wind/WAF paper, and the work of Alexander and Cruz (2012) (Table 1 and S1) that shows different vegetation type dependent relationships for deriving flame height based on fire intensity.

Previously we had used the single relationship based on Byram (1959) (also included in Table 1 of Alexander and Cruz (2012)) to derive flame height from FRP, and here we extend it to a methodology that is approximately related to model input vegetation type (currently supporting MODIS/VIIRS).

For the limited SE example using the FRP to flame height only option in canopy-app:

Byram (1959) Flame Heights
image

Alexander and Cruz (2012) - Byram (1959) Flame Heights
image

@angehung5 When you return from leave, can you more robustly help test this new feature?

@drnimbusrain drnimbusrain added the enhancement New feature or request label Aug 30, 2023
@drnimbusrain drnimbusrain marked this pull request as draft August 31, 2023 18:03
@drnimbusrain drnimbusrain marked this pull request as ready for review August 31, 2023 19:01
@drnimbusrain drnimbusrain marked this pull request as draft September 1, 2023 18:17
@drnimbusrain
Copy link
Member Author

I convert this to a draft, as when reading Alexander and Cruz, it may be more appropriate to use a vegtype dependent calculations of crown scorch height (hs), which can be related directly to flame height (hf) (see Table 2 and equation 14 in their paper). I will add this option as well.

@drnimbusrain
Copy link
Member Author

I have added the additional option (flameh_frp) to use the vegtype dependent scorch height to flame height relationships from Alexander and Cruz.

Overall, the differences compared to Byram (1959) only are similar as previous for the vegtype dependence, but the different relationship for grasslands/savanna/shublands/crops using scorch heights cause larger flame heights in this case for one grid cell:
image

@drnimbusrain drnimbusrain marked this pull request as ready for review September 5, 2023 02:15
@drnimbusrain drnimbusrain added the help wanted Extra attention is needed label Sep 18, 2023
@drnimbusrain
Copy link
Member Author

@angehung5 What do you think about this PR, will you give it a review? Not sure it will have enough impact yet to warrant changing your paper results for midflame wind and WAF. However, you mentioned you had comments on the new NL variable flameh_frp. Also note that I have merged in the latest develop which contains multiple timesteps. Thank you!

Copy link
Collaborator

@angehung5 angehung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I haven't get a chance to test it, but I changed flameh_frp to flameh_cal (option for flameh calculation). Hope it is more clear.
You can go ahead and merge it to develop. I will find time to run some tests later.

@drnimbusrain drnimbusrain merged commit 5493605 into develop Sep 29, 2023
4 checks passed
@drnimbusrain drnimbusrain deleted the feature/frp_flameh branch September 29, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fires] Add VegType Dependent FRP to Flame Height Calculation
2 participants