lookup: remove vinyl-fs #1030
Closed
lookup: remove vinyl-fs #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1030 +/- ##
==========================================
- Coverage 96.33% 95.04% -1.29%
==========================================
Files 28 28
Lines 2181 2181
==========================================
- Hits 2101 2073 -28
- Misses 80 108 +28 ☔ View full report in Codecov by Sentry. |
ljharb
approved these changes
Nov 22, 2023
|
Superseded by #1036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #444
Refs: #537
This module has been marked flaky since at least 2017, and skipped for 3 years. At this point, I think we should consider removing it as it hasn't been used for our regression testing for so long. The test suite also consistently fails locally for me on Node.js 18+, and on all platforms (refs).