lib: skip flaky modules on v21 #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
+ Coverage 95.23% 96.33% +1.10%
==========================================
Files 28 28
Lines 2181 2181
==========================================
+ Hits 2077 2101 +24
+ Misses 104 80 -24 ☔ View full report in Codecov by Sentry. |
|
Is there anything actionnable for us? Seems like just timeout happening in Node 21 🤔 |
aduh95
approved these changes
Dec 12, 2023
|
@SBoudrias It's not timeouts: https://ci.nodejs.org/job/citgm-smoker/3351/nodes=fedora-last-latest-x64/testReport/junit/(root)/citgm/yeoman_generator_v7_1_1/ Most (if not all) errors are |
targos
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1033
Pinging module authors again: