lookup: increase acorn timeout to 30 minutes #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acorn needs more time so that it can install the test262 dependencies (which we then won't use/test, but what can you do?).
|
Running https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3219/ to see if this timeout is long enough. |
anonrig
approved these changes
Sep 8, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2140 2140
=======================================
Hits 2064 2064
Misses 76 76 ☔ View full report in Codecov by Sentry. |
|
With 30 minutes for a timeout, it passes in a few places but still times out in others. I think the best thing to do, especially since the lengthy install isn't used by the tests anyway, is to remove acorn from the test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acorn needs more time so that it can install the test262 dependencies (which we then won't use/test, but what can you do?).
Checklist
npm testpasseshere