Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping pino on aix and s390x #972

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Skipping pino on aix and s390x #972

merged 1 commit into from
Sep 11, 2023

Conversation

mcollina
Copy link
Member

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3223

There seems to be some binary issue with a test dependency.

Ref. #959

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3223

There seems to be some binary issue with a test dependency.
@mcollina mcollina requested a review from Trott September 11, 2023 07:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e8b77ad) 96.44% compared to head (150d609) 96.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcollina mcollina merged commit cf8b384 into main Sep 11, 2023
11 checks passed
@mcollina mcollina deleted the skip-pino branch September 11, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants