Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-watch-mode (again) #44735

Closed
tniessen opened this issue Sep 20, 2022 · 1 comment · Fixed by #44739
Closed

Investigate flaky test-watch-mode (again) #44735

tniessen opened this issue Sep 20, 2022 · 1 comment · Fixed by #44739
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. watch-mode Issues and PRs related to watch mode

Comments

@tniessen
Copy link
Member

Test

test-watch-mode

Platform

Other

Console output

................. failed 9 out of 10
F......
=== release test-watch-mode ===
Path: sequential/test-watch-mode
Error: --- stderr ---
(node:162497) ExperimentalWarning: The test runner is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
--- stdout ---
TAP version 13
# Subtest: watch mode
    # Subtest: should watch changes to a file - event loop ended
    ok 1 - should watch changes to a file - event loop ended
      ---
      duration_ms: 5906.611153
      ...
    # Subtest: should watch changes to a failing file
    not ok 2 - should watch changes to a failing file
      ---
      duration_ms: 5788.259684
      failureType: 'testCodeFailure'
      error: |-
        Expected values to be strictly equal:
        
        4 !== 2
        
      code: 'ERR_ASSERTION'
      stack: |-
        Object.<anonymous> (file:///home/runner/work/node/node/test/sequential/test-watch-mode.mjs:98:12)
        process.processTicksAndRejections (node:internal/process/task_queues:95:5)
        async ItTest.run (node:internal/test_runner/test:487:9)
        async Promise.all (index 1)
        async Suite.run (node:internal/test_runner/test:714:7)
      ...
    # Subtest: should not watch when running an non-existing file
    ok 3 - should not watch when running an non-existing file
      ---
      duration_ms: 2114.841664
      ...
    # Subtest: should watch when running an non-existing file - when specified under --watch-path
    ok 4 - should watch when running an non-existing file - when specified under --watch-path # SKIP
      ---
      duration_ms: 204.626377
      ...
    # Subtest: should watch changes to a file - event loop blocked
    ok 5 - should watch changes to a file - event loop blocked
      ---
      duration_ms: 3607.078136
      ...
    # Subtest: should watch changes to dependencies - cjs
    ok 6 - should watch changes to dependencies - cjs
      ---
      duration_ms: 5882.811789
      ...
    # Subtest: should watch changes to dependencies - esm
    ok 7 - should watch changes to dependencies - esm
      ---
      duration_ms: 5907.785376
      ...
    # Subtest: should restart multiple times
    ok 8 - should restart multiple times
      ---
      duration_ms: 5031.92522
      ...
    # Subtest: should pass arguments to file
    ok 9 - should pass arguments to file
      ---
      duration_ms: 5189.698885
      ...
    # Subtest: should not load --require modules in main process
    ok 10 - should not load --require modules in main process
      ---
      duration_ms: 5671.436746
      ...
    # Subtest: should not load --import modules in main process
    ok 11 - should not load --import modules in main process
      ---
      duration_ms: 4714.783331
      ...
    1..11
not ok 1 - watch mode
  ---
  duration_ms: 6009.677812
  failureType: 'subtestsFailed'
  error: '1 subtest failed'
  code: 'ERR_TEST_FAILURE'
  ...
1..1
# tests 1
# pass 0
# fail 1
# cancelled 0
# skipped 0
# todo 0
# duration_ms 6023.304411
Command: out/Release/node /home/runner/work/node/node/test/sequential/test-watch-mode.mjs

===
=== 1 tests failed
===

Build links

Additional information

#44655 was closed by #44621, which was merged as 96f0722. That very commit failed the test in GitHub actions as shown above...

@tniessen tniessen added flaky-test Issues and PRs related to the tests with unstable failures on the CI. test_runner Issues and PRs related to the test runner subsystem. labels Sep 20, 2022
@MoLow MoLow removed the test_runner Issues and PRs related to the test runner subsystem. label Sep 20, 2022
@MoLow
Copy link
Member

MoLow commented Sep 20, 2022

I actually ran stress tests on Jenkins - so that was probably missed. opening a PR

nodejs-github-bot pushed a commit that referenced this issue Sep 25, 2022
PR-URL: #44739
Fixes: #44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
PR-URL: #44739
Fixes: #44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this issue Sep 26, 2022
PR-URL: #44739
Fixes: #44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this issue Sep 29, 2022
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44815
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this issue Oct 2, 2022
PR-URL: #44739
Backport-PR-URL: #44815
Fixes: #44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this issue Oct 3, 2022
PR-URL: nodejs#44739
Backport-PR-URL: https://github.com/nodejs/node/pull/TBD
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this issue Oct 3, 2022
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44877
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44877
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this issue Oct 12, 2022
PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
richardlau pushed a commit that referenced this issue Nov 23, 2022
PR-URL: #44739
Backport-PR-URL: #44976
Fixes: #44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
PR-URL: nodejs/node#44739
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
PR-URL: nodejs/node#44739
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44735
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. watch-mode Issues and PRs related to watch mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants