Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.1.0 proposal #45269

Merged
merged 200 commits into from
Nov 14, 2022
Merged

v19.1.0 proposal #45269

merged 200 commits into from
Nov 14, 2022

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Nov 1, 2022

2022-11-14, Version 19.1.0 (Current), @RafaelGSS

Notable changes

Support function mocking on Node.js test runner

The node:test module supports mocking during testing via a top-level mock
object.

test('spies on an object method', (t) => {
  const number = {
    value: 5,
    add(a) {
      return this.value + a;
    },
  };
  t.mock.method(number, 'add');

  assert.strictEqual(number.add(3), 8);
  assert.strictEqual(number.add.mock.calls.length, 1);
});

Contributed by Colin Ihrig in #45326

fs.watch recursive support on Linux

fs.watch supports recursive watch using the recursive: true option.

const watcher = fs.watch(testDirectory, { recursive: true });
watcher.on('change', function(event, filename) {
});

Contributed by Yagiz Nizipli in #45098

Other notable changes

  • deps
    • update ICU to 72.1 (Michaël Zasso) #45068
  • doc
    • add lukekarrys to collaborators (Luke Karrys) #45180
    • add anonrig to collaborators (Yagiz Nizipli) #45002
  • lib
    • drop fetch experimental warning (Matteo Collina) #45287
  • util
    • (SEMVER-MINOR) add MIME utilities (Bradley Farias) #21128
    • improve textdecoder decode performance (Yagiz Nizipli) #45294

Commits

@RafaelGSS RafaelGSS added release Issues and PRs related to Node.js releases. v19.x labels Nov 1, 2022
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Nov 1, 2022
@RafaelGSS RafaelGSS added request-ci Add this label to start a Jenkins CI on a PR. and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Nov 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2022
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

Date should be 2022-11-02 🙂

@ovflowd
Copy link
Member

ovflowd commented Nov 1, 2022

:shipit: 👀

RafaelGSS added a commit that referenced this pull request Nov 1, 2022
Notable changes:

* deps:
  * update ICU to 72.1 (Michaël Zasso) [#45068](#45068)
* doc:
  * add lukekarrys to collaborators (Luke Karrys) [#45180](#45180)
  * add anonrig to collaborators (Yagiz Nizipli) [#45002](#45002)
* fs:
  * (SEMVER-MINOR) fs: add recursive watch to linux (Yagiz Nizipli) [#45098](#45098)
* util
  * (SEMVER-MINOR) add MIME utilities (Bradley Farias) [#21128](#21128)

PR-URL: #45269
RafaelGSS added a commit that referenced this pull request Nov 1, 2022
Notable changes:

* deps:
  * update ICU to 72.1 (Michaël Zasso) [#45068](#45068)
* doc:
  * add lukekarrys to collaborators (Luke Karrys) [#45180](#45180)
  * add anonrig to collaborators (Yagiz Nizipli) [#45002](#45002)
* fs:
  * (SEMVER-MINOR) fs: add recursive watch to linux (Yagiz Nizipli) [#45098](#45098)
* util
  * (SEMVER-MINOR) add MIME utilities (Bradley Farias) [#21128](#21128)

PR-URL: #45269
RafaelGSS added a commit that referenced this pull request Nov 1, 2022
Notable changes:

* deps:
  * update ICU to 72.1 (Michaël Zasso) [#45068](#45068)
* doc:
  * add lukekarrys to collaborators (Luke Karrys) [#45180](#45180)
  * add anonrig to collaborators (Yagiz Nizipli) [#45002](#45002)
* fs:
  * (SEMVER-MINOR) fs: add recursive watch to linux (Yagiz Nizipli) [#45098](#45098)
* util
  * (SEMVER-MINOR) add MIME utilities (Bradley Farias) [#21128](#21128)

PR-URL: #45269
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 1, 2022

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS
Copy link
Member Author

FYI We'll delay it to happen after the Security Release.

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2022

@anonrig
Copy link
Member

anonrig commented Nov 12, 2022

@RafaelGSS Can we include the latest utf-8 fast path pull request?

@bricss
Copy link

bricss commented Nov 12, 2022

Maybe it's also not to late to pull #45139 🙄

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Nov 12, 2022

I prefer to include both in the next release. This release is already delayed and I have no bandwidth to include it over the weekend (considering it should be ready to be released on Monday). Sorry folks.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as duplicate.

@nodejs-github-bot

This comment was marked as duplicate.

@RafaelGSS RafaelGSS merged commit 0237cff into v19.x Nov 14, 2022
@RafaelGSS RafaelGSS deleted the v19.1.0-proposal branch November 14, 2022 13:27
RafaelGSS added a commit that referenced this pull request Nov 14, 2022
RafaelGSS added a commit that referenced this pull request Nov 14, 2022
Notable changes:

* deps:
  * update ICU to 72.1 (Michaël Zasso) [#45068](#45068)
* doc:
  * add lukekarrys to collaborators (Luke Karrys) [#45180](#45180)
  * add anonrig to collaborators (Yagiz Nizipli) [#45002](#45002)
* fs:
  * (SEMVER-MINOR) fs: add recursive watch to linux (Yagiz Nizipli) [#45098](#45098)
* lib:
  * drop fetch experimental warning (Matteo Collina) [#45287](#45287)
* test_runner:
  * support function mocking (Colin Ihrig) [#45326](#45326)
* util
  * (SEMVER-MINOR) add MIME utilities (Bradley Farias) [#21128](#21128)
  * improve textdecoder decode performance (Yagiz Nizipli) [#45294](#45294)

PR-URL: #45269
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Nov 14, 2022
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Nov 14, 2022
@mscdex
Copy link
Contributor

mscdex commented Nov 14, 2022

@RafaelGSS The main CHANGELOG.md needs to be updated with the current v19 version as well. Without it, it's currently causing markdown linting errors in PRs.

@RafaelGSS
Copy link
Member Author

#45462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.