-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "src: make sure pass the argv
to worker threads"
#53021
Revert "src: make sure pass the argv
to worker threads"
#53021
Conversation
dd4cd0c
to
33bbb6c
Compare
What should I do about the cpp formatter failure? Edit the revert commit so that it doesn't only revert, but also fix formatting? Or add a new commit just to format? |
33bbb6c
to
2c65c8d
Compare
It should be possible to pass the `env` option to a worker even when the parent process is using a process-level flag, such as `--title` or a V8-specific flag. This test is currently failing in Node.js 22.2.0
This reverts commit aba4a00.
2c65c8d
to
e05e072
Compare
I misread what you were asking. I'm not in any way the person to give advice on this, but I'd add a new commit for now, they can always be changed later |
I would add a fixup commit ( Shouldn't the revert comes first, then the added test can be applied? Otherwise tests won't be passing on that first commit IIUC |
I have opened an PR and try to fix this. |
Closing in favor of #53029 |
aba4a00 introduced a regression, making it impossible to use
Worker
'senv
option when the process is start with process-specific flags, such as--title
or--expose_gc
. See the new test case, in which all the threenew Worker()
calls fail.aba4a00 was released yesterday in 22.2.0.
Commit 1:
Commit 2:
Fixes #53011, cc @theanarkh