Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: clarify release notes for v14.21.2 and v16.19.0 #4972

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

richardlau
Copy link
Member

cc @ljharb

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It’d be ideal to also add “(SEMVER-MINOR)” to the semver-minor item(s) in the 16.19 commit list as well, since that’s how i usually scan to see what’s added :-)

@@ -12,8 +12,7 @@ author: Richard Lau

#### OpenSSL 1.1.1s

This update is a bugfix release and does not address any security
vulnerabilities.
This OpenSSL version does not address any security vulnerabilities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change might not be needed, since it’s a patch release

@richardlau
Copy link
Member Author

Thanks! It’d be ideal to also add “(SEMVER-MINOR)” to the semver-minor item(s) in the 16.19 commit list as well, since that’s how i usually scan to see what’s added :-)

Updated.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Trott Trott merged commit 26e8085 into nodejs:main Dec 13, 2022
@richardlau richardlau deleted the v16.19.0 branch December 13, 2022 19:46
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Dec 21, 2022
Refs: #45775
PR-URL: #45846
Refs: nodejs/nodejs.org#4972
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Dec 21, 2022
Refs: #45791
PR-URL: #45846
Refs: nodejs/nodejs.org#4972
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau added a commit to nodejs/node that referenced this pull request Dec 21, 2022
Refs: #45775
PR-URL: #45846
Refs: nodejs/nodejs.org#4972
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
richardlau added a commit to nodejs/node that referenced this pull request Dec 21, 2022
Refs: #45791
PR-URL: #45846
Refs: nodejs/nodejs.org#4972
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
oraluben pushed a commit to oraluben/node that referenced this pull request Mar 14, 2023
oraluben pushed a commit to oraluben/node that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants