-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HTTP/2] Aborted requests for same domain might fail unexpectedly #2364
Comments
Started doing some research about, and bug is in fact quite complex; it seems that somewhere we are reusing a |
The repro SukkaW provided still reproduces even with Pipelining disabled, maybe this issue should be re-titled? Trying to swap to undici in our software, I'm able to get this stack trace, we only issue one request to a dummy /debug/stream endpoint which pushes one sse per second and abort it after a few seconds. but we receive exactly one more chunk afterwards, resulting in this assertion failure
|
Bug Description
As the title, pipelined requests might fail unexpectedly if another request toward the same domain has been aborted:
Reproducible By
https://replit.com/@isukkaw/undici-h2-promise-any
Expected Behavior
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: assert(!this.aborted)
should never happened.Logs & Screenshots
Environment
Node.js 18.16.0 on Ubuntu 22.04.1
The text was updated successfully, but these errors were encountered: