Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix Request.refererPolicy and RequestInit.refererPolicy are incompatible #3039

Merged
merged 1 commit into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/types/fetch.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ expectType<string>(request.integrity)
expectType<string>(request.method)
expectType<RequestMode>(request.mode)
expectType<RequestRedirect>(request.redirect)
expectType<string>(request.referrerPolicy)
expectType<ReferrerPolicy>(request.referrerPolicy)
expectType<string>(request.url)
expectType<boolean>(request.keepalive)
expectType<AbortSignal>(request.signal)
Expand Down Expand Up @@ -172,3 +172,5 @@ expectAssignable<RequestInit>({ duplex: 'half' })
expectNotAssignable<RequestInit>({ duplex: 'not valid' })

expectType<string[]>(headers.getSetCookie())

expectType<Request>(new Request('https://example.com', request))
2 changes: 1 addition & 1 deletion types/fetch.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export declare class Request extends BodyMixin {
readonly method: string
readonly mode: RequestMode
readonly redirect: RequestRedirect
readonly referrerPolicy: string
readonly referrerPolicy: ReferrerPolicy
readonly url: string

readonly keepalive: boolean
Expand Down
Loading