pull ruby build #909
Merged
pull ruby build #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Sharma <[email protected]>
It performs differential ShellCheck scans and report results directly in pull request. documentation: https://github.com/redhat-plumbers-in-action/differential-shellcheck Signed-off-by: Jan Macku <[email protected]>
ci(lint): add shell linter - Differential ShellCheck
MRI's BigInt use GMP under the hood if available, and if not
fallbacks to an homemade implementation with much worse performance.
Without GMP:
```
>> Benchmark.realtime { Integer('1' * (10 ** 7)) }
=> 13.80743500002427
```
With GMP
```
>> Benchmark.realtime { Integer('1' * (10 ** 7)) }
=> 0.4098639999865554
```
macOS not being a common production platform, it's not a huge deal
but it would still preferable to compile with `gmp.h` if present.
I'd also suggest to print a warning if compiling on macOS and gmp
isn't installed, but I don't know if it's desirable.
NB: `--with-gmp-dir` was only added recently, so this will only
apply to MRI >= 3.2, as well as rubies on which this flag was backported.
macOS: Use GMP from homebrew
Allow OPENSSL_VERSION_TEXT string match without last line for OpenSUSE
Upon installing their first Ruby version on the system, the user may want to set it as their default; otherwise the default will remain "system" and any `gem install` attempts will fail with a permission error. This suggestion is skipped if the user already has chosen an explicit default, even if it's "system".
This makes it easier to redirect `rbenv install -l` output without having to silence stderr to get rid of the extra notice.
List output: only print stderr notice if printing to a terminal
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
* commit 'refs/rbtags/v20220930': ruby-build 20220930 Release with gh instead of with hub (#2056) List output: only print stderr notice if printing to a terminal Touch up README for comprehension and clarity (#2051) Suggest `rbenv global` if there is no explicit global setting (#2052) macOS: Use GMP from homebrew Allow OPENSSL_VERSION_TEXT string match without last line for OpenSUSE Add JRuby 9.3.8.0 ci(lint): Add differential-shellcheck action Add minimum GitHub token permissions for workflows
jasonkarns
force-pushed
the
pull-ruby-build
branch
from
cec08cb
to
0a1d084
Compare
jasonkarns
force-pushed
the
pull-ruby-build
branch
from
0a1d084
to
0007dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges ruby-build 20220930.
The changes for openssl and GMP from that release have been removed. see #910
ruby-build commits
rbenv globalif there is no explicit global setting (#2052)