Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom fontFamily? #2

Closed
kepbod opened this issue Feb 21, 2017 · 3 comments
Closed

Use custom fontFamily? #2

kepbod opened this issue Feb 21, 2017 · 3 comments
Labels
context-api priority-high scope-compatibility scope-ux type-bug
Milestone
0.1.1

Comments

@kepbod
Copy link

kepbod commented Feb 21, 2017

According to index.js, nord-hyper uses Source Code Pro or Hack font first. If users set the custom fontFamily, it won't use it. Are there any solutions? Thanks a lot.

PS: I found a typo in the README, and it should be ⌘ + , instead of ⌘ +.
@arcticicestudio arcticicestudio self-assigned this Feb 21, 2017
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Feb 21, 2017 •
edited
Loading

This is a bug, the order should be to use config.fontFamily first and the defined fonts as fallback.
I'll fix the typo and the order with the next patch, thanks 👍

@arcticicestudio arcticicestudio mentioned this issue Feb 21, 2017
Closed
arcticicestudio added a commit that referenced this issue Feb 21, 2017
@arcticicestudio
GHI-#2 Fix keymaps for configuration file (re)loading
d160471
@arcticicestudio
Copy link
Contributor

Fixed in #3 and shipped in npm 📦 release version 🏷️ 0.1.1

@kepbod
Copy link
Author

kepbod commented Feb 21, 2017

Cool 👍

@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
@arcticicestudio arcticicestudio added this to the 0.1.1 milestone Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-api priority-high scope-compatibility scope-ux type-bug
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
2 participants
@kepbod @arcticicestudio