Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent leaking pipe FDs to other subprocess #20

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Prevent leaking pipe FDs to other subprocess #20

merged 1 commit into from
Apr 22, 2024

Conversation

norihiro
Copy link
Owner

@norihiro norihiro commented Apr 21, 2024 •
edited
Loading

Description

To avoid holding unnecessary FDs, set CLOEXEC flag to the pipe FDs.

The leaking FDs won't hurt any functionality because this plugin sends a CAPDEV_REQ_FLAG_EXIT flag to let the subprocess exit.

How Has This Been Tested?

  • Test on Linux
  • Test on macOS

General checklist

  • The commit is reviewed by yourself.
  • The code is tested.
  • Document is up to date or not necessary to be changed.
  • The commit is compatible with repository's license.

@norihiro norihiro self-assigned this Apr 21, 2024
@norihiro
Prevent leaking pipe FDs to other subprocess
f7c4ed6 
To avoid holding unnecessary FDs, set CLOEXEC flag to the pipe FDs.
@norihiro norihiro merged commit ffbfb6a into main Apr 22, 2024
6 checks passed
@norihiro norihiro deleted the pipe2-O_CLOEXEC branch April 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@norihiro norihiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@norihiro