update: logs and error messages #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 73.55% 73.26% -0.30%
==========================================
Files 23 23
Lines 1732 1743 +11
==========================================
+ Hits 1274 1277 +3
- Misses 366 372 +6
- Partials 92 94 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
patrickzheng200
requested review from
shizhMSFT,
JeyJeyGao,
priteshbandi and
rgnote
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
patrickzheng200
changed the title
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Dec 19, 2022
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
approved these changes
Dec 20, 2022
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more logs to the library and improves error messages.
This PR intends to resolve following issues:
notaryproject/notation#462
notaryproject/notation#128 -> comments related to trust policy