Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin version comparison functionality #237

Merged
merged 6 commits into from
Feb 2, 2023

Conversation

iamjesh
Copy link
Contributor

@iamjesh iamjesh commented Jan 5, 2023

Ensuring that the the verification plugin version is higher than the minimum plugin version emitted from the signature

go.mod Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #237 (b30c0c6) into main (ed6ff0c) will increase coverage by 0.09%.
The diff coverage is 68.75%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   73.25%   73.35%   +0.09%     
==========================================
  Files          23       23              
  Lines        1761     1775      +14     
==========================================
+ Hits         1290     1302      +12     
+ Misses        376      375       -1     
- Partials       95       98       +3     
Impacted Files Coverage Δ
verifier/helpers.go 69.73% <66.66%> (+2.16%) ⬆️
verifier/verifier.go 73.50% <69.23%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/mock/mocks.go Outdated Show resolved Hide resolved
verifier/helpers.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
…and Verification plugin version)

Signed-off-by: Jeswanth <[email protected]>
…and Verification plugin version) Signed-off-by: Jeswanth Galla [email protected]

Signed-off-by: Jeswanth <[email protected]>
…and Verification plugin version)

Signed-off-by: Jeswanth <[email protected]>
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
@priteshbandi priteshbandi linked an issue Jan 13, 2023 that may be closed by this pull request
…and Verification plugin version

Signed-off-by: Jeswanth <[email protected]>
internal/mock/mocks.go Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
verifier/helpers.go Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT changed the title Plugin version comparison functionality feat: plugin version comparison functionality Jan 18, 2023
verifier/helpers.go Outdated Show resolved Hide resolved
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like build is failing.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao
Copy link
Contributor

Please resolve the conflicting files.

verifier/helpers_test.go Outdated Show resolved Hide resolved
…and Verification plugin version

Signed-off-by: Jeswanth <[email protected]>
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 32d2372 into notaryproject:main Feb 2, 2023
@JeyJeyGao JeyJeyGao mentioned this pull request Feb 3, 2023
priteshbandi added a commit to priteshbandi/notation-go that referenced this pull request Feb 3, 2023
Ensures that the the verification plugin version is higher than the minimum plugin version emitted from the signature

Signed-off-by: Jeswanth <[email protected]>
Co-authored-by: Pritesh Bandi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Semantic Versioning
6 participants