feat: support OCI image manifest #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
==========================================
- Coverage 73.31% 73.25% -0.06%
==========================================
Files 23 23
Lines 1746 1761 +15
==========================================
+ Hits 1280 1290 +10
- Misses 372 376 +4
- Partials 94 95 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shizhMSFT
reviewed
Jan 12, 2023
shizhMSFT
changed the title
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Jan 13, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Jan 13, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
reviewed
Jan 16, 2023
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
LGTM
Although we will need to do some additional work for notaryproject/specifications#219 & notaryproject/specifications#220; this will act as a stepping stone.
priteshbandi
pushed a commit
to priteshbandi/notation-go
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
priteshbandi
pushed a commit
to priteshbandi/notation-go
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
priteshbandi
pushed a commit
to priteshbandi/notation-go
that referenced
this pull request
Feb 1, 2023
Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
priteshbandi
pushed a commit
to priteshbandi/notation-go
that referenced
this pull request
Feb 3, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the implementation of the spec.
Tested with [COSE, JWS] + [OCI artifact manifest, OCI image manifest] on ACR.