Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more unit test for keys.go #268

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

priteshbandi
Copy link
Contributor

Adds more unit test for keys.go

Signed-off-by: Pritesh Bandi [email protected]

Signed-off-by: Pritesh Bandi <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #268 (5dc299e) into main (510def1) will increase coverage by 4.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   69.56%   73.59%   +4.03%     
==========================================
  Files          23       23              
  Lines        1909     1909              
==========================================
+ Hits         1328     1405      +77     
+ Misses        483      405      -78     
- Partials       98       99       +1     
Impacted Files Coverage Δ
config/keys.go 71.89% <0.00%> (+50.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit d44cb5d into notaryproject:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants