Added CODEOWNERS and MAINTAINERS files #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toddy Mladenov <[email protected]>
toddysm
requested review from
justincormack,
sajayantony,
qmuntal,
gokarnm,
rgnote,
lachie83,
priteshbandi,
SteveLasker,
shizhMSFT,
FeynmanZhou,
JeyJeyGao,
NiazFK,
iamsamirzon,
patrickzheng200,
yizha1 and
vaninrao10
Signed-off-by: Toddy Mladenov <[email protected]>
Signed-off-by: Toddy Mladenov <[email protected]>
vaninrao10
requested changes
Feb 8, 2023
There was a problem hiding this comment.
In Maintainers file Rakesh Gokarn [email protected] (@rgnote) need to be changed to Rakesh Gariganti [email protected] (@rgnote)
Signed-off-by: Toddy Mladenov <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 73.53% 73.24% -0.29%
==========================================
Files 23 23
Lines 1923 1985 +62
==========================================
+ Hits 1414 1454 +40
- Misses 410 429 +19
- Partials 99 102 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Linking the issue #249 |
iamsamirzon
approved these changes
Feb 14, 2023
SteveLasker
approved these changes
Feb 15, 2023
justincormack
approved these changes
Feb 16, 2023
This was referenced Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Toddy Mladenov [email protected]
This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notation-go sub-project:
Add Junjie Gao #265
Add Milind Gokarn #259
Add Patrick Zheng #264
Add Pritesh Bandi #258
Add Rakesh Gariganti #260
Add Shiwei Zhang #263
The proposal is to abandon the above PRs and merge only this one.