Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up comments format and removed unused code #273

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

patrickzheng200
Copy link
Contributor

go fmt.
Cleaned up comments format.
Removed unused code in unit tests.

Signed-off-by: Patrick Zheng [email protected]

@patrickzheng200 patrickzheng200 self-assigned this Feb 9, 2023
@patrickzheng200 patrickzheng200 added this to the RC-2 milestone Feb 9, 2023
@patrickzheng200 patrickzheng200 changed the title chore: clean up comment formats and removed unused code chore: clean up comments format and removed unused code Feb 9, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/keys_test.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #273 (6f09cb1) into main (1b2ec27) will increase coverage by 0.12%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   73.24%   73.37%   +0.12%     
==========================================
  Files          23       23              
  Lines        1985     1994       +9     
==========================================
+ Hits         1454     1463       +9     
  Misses        429      429              
  Partials      102      102              
Impacted Files Coverage Δ
errors.go 0.00% <ø> (ø)
notation.go 55.15% <ø> (ø)
plugin/plugin.go 95.16% <ø> (ø)
plugin/proto/verify.go 0.00% <ø> (ø)
config/keys.go 71.89% <100.00%> (ø)
signer/plugin.go 66.98% <100.00%> (+0.15%) ⬆️
verifier/helpers.go 70.51% <100.00%> (+0.77%) ⬆️
verifier/trustpolicy/trustpolicy.go 92.96% <100.00%> (+0.02%) ⬆️
verifier/verifier.go 76.95% <100.00%> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shizhMSFT shizhMSFT merged commit 7987c85 into notaryproject:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants