Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump image-spec to v1.1.0-rc.3 and oras-go to v2.1.0 #306

Merged
merged 1 commit into from
May 10, 2023

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented May 5, 2023

Closes #305
Closes #307

@shizhMSFT shizhMSFT added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 5, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #306 (affc103) into main (06d04cc) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files          23       23           
  Lines        2175     2175           
=======================================
  Hits         1618     1618           
  Misses        439      439           
  Partials      118      118           
Impacted Files Coverage Δ
registry/repository.go 49.35% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sajayantony
Copy link
Contributor

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

@rchincha
Copy link

rchincha commented May 5, 2023

Also, under "internal/" so external imports don't work yet.

@FeynmanZhou
Copy link
Member

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

Agree with @sajayantony. This change is also supposed to be considered in Notation CLI.

@shizhMSFT
Copy link
Contributor Author

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

This is partially addressed by #308. We might need more discussions on the warning and it can be done in another PR.

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit efa353a into notaryproject:main May 10, 2023
@shizhMSFT shizhMSFT deleted the bump-image-spec branch May 10, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants