feat: add validations for symlink #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priteshbandi
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
rgnote,
shizhMSFT,
SteveLasker and
Two-Hearts
as code owners
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 74.80% 74.80%
=======================================
Files 23 23
Lines 2179 2203 +24
=======================================
+ Hits 1630 1648 +18
- Misses 433 437 +4
- Partials 116 118 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JeyJeyGao
reviewed
May 24, 2023
shizhMSFT
reviewed
May 24, 2023
shizhMSFT
changed the title
Two-Hearts
reviewed
May 24, 2023
priteshbandi
force-pushed
the
symlink
branch
2 times, most recently
from
e9f1be7
to
1a1dfca
Compare
Two-Hearts
reviewed
May 24, 2023
priteshbandi
force-pushed
the
symlink
branch
2 times, most recently
from
3274970
to
29e5a81
Compare
|
@priteshbandi it seems that your commits are not signed? Otherwise, LGTM. |
priteshbandi
force-pushed
the
symlink
branch
2 times, most recently
from
8ee79be
to
5e3dc2e
Compare
Signed-off-by: Pritesh Bandi <[email protected]>
Fixed the issue, the email address in git config was incorrect. |
shizhMSFT
approved these changes
May 25, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validations to make sure singingkeys.json, trustpolicy.json and config.json doesnt read's symlink
closes notaryproject/notation#634