-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add validations for symlink #316
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #316 +/- ##
=======================================
Coverage 74.80% 74.80%
=======================================
Files 23 23
Lines 2179 2203 +24
=======================================
+ Hits 1630 1648 +18
- Misses 433 437 +4
- Partials 116 118 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e9f1be7
to
1a1dfca
Compare
3274970
to
29e5a81
Compare
@priteshbandi it seems that your commits are not signed? Otherwise, LGTM. |
8ee79be
to
5e3dc2e
Compare
Signed-off-by: Pritesh Bandi <[email protected]>
Fixed the issue, the email address in git config was incorrect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we definitely can refactor the open file sub-routine in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added validations to make sure singingkeys.json, trustpolicy.json and config.json doesnt read's symlink
closes notaryproject/notation#634