fix: update timeout for OCSP call to 2 seconds #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pritesh Bandi <[email protected]>
priteshbandi
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
rgnote,
shizhMSFT,
SteveLasker and
Two-Hearts
as code owners
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 74.80% 74.80%
=======================================
Files 23 23
Lines 2203 2203
=======================================
Hits 1648 1648
Misses 437 437
Partials 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shizhMSFT
changed the title
shizhMSFT
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
LGTM. Should we merge this PR after merging notaryproject/specifications#249?
|
Agree with @shizhMSFT , we need to merge the spec first, then the implementation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated timeout for OCSP call to 2 seconds.
Updates based on updates in notaryproject/specifications#249