Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: update oras-go to v2.3.0 #347

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Aug 31, 2023

  • Update oras-go to v2.3.0.
  • Replace oras.Pack() with oras.PackManifest() as it is deprecated in v2.3.0.
  • Generate an empty config blob manually, as oras.PackManifest() does not generate the config blob with the notation artifact type as the media type.

Resolves #346
Signed-off-by: Junjie Gao [email protected]

Signed-off-by: Junjie Gao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #347 (0b41645) into main (f1706c2) will decrease coverage by 0.21%.
The diff coverage is 59.09%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   74.88%   74.68%   -0.21%     
==========================================
  Files          23       23              
  Lines        2210     2228      +18     
==========================================
+ Hits         1655     1664       +9     
- Misses        437      443       +6     
- Partials      118      121       +3     
Files Changed Coverage Δ
registry/repository.go 49.41% <59.09%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Junjie Gao <[email protected]>
Two-Hearts
Two-Hearts previously approved these changes Aug 31, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

registry/repository.go Outdated Show resolved Hide resolved
@shizhMSFT shizhMSFT changed the title fix: update oras-go v2.3.0 bump: update oras-go to v2.3.0 Aug 31, 2023
shizhMSFT
shizhMSFT previously approved these changes Aug 31, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

registry/repository.go Outdated Show resolved Hide resolved
registry/repository.go Outdated Show resolved Hide resolved
registry/repository.go Outdated Show resolved Hide resolved
registry/repository.go Outdated Show resolved Hide resolved
registry/repository.go Outdated Show resolved Hide resolved
@JeyJeyGao JeyJeyGao dismissed stale reviews from shizhMSFT and Two-Hearts via 9dfdb3b September 1, 2023 02:09
Signed-off-by: Junjie Gao <[email protected]>
shizhMSFT
shizhMSFT previously approved these changes Sep 1, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <[email protected]>
Copy link
Contributor

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 60d9cdc into notaryproject:main Sep 15, 2023
7 checks passed
Two-Hearts pushed a commit to Two-Hearts/notation-go that referenced this pull request Sep 18, 2023
- Update oras-go to v2.3.0.
- Replace oras.Pack() with oras.PackManifest() as it is deprecated in
v2.3.0.
- Generate an empty config blob manually, as oras.PackManifest() does
not generate the config blob with the notation artifact type as the
media type.

Resolves notaryproject#346
Signed-off-by: Junjie Gao <[email protected]>

---------

Signed-off-by: Junjie Gao <[email protected]>
@shizhMSFT shizhMSFT mentioned this pull request Oct 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oras-go updated v2.3.0
7 participants