-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implements VerifyBlob functionality #394
Conversation
…quest (notaryproject#390) Add contract version to plugin sign request and plugin verify request. As per [specification](https://github.com/notaryproject/specifications/blob/main/specs/plugin-extensibility.md) `contractVersion` is a mandatory field. Signed-off-by: Pritesh Bandi <[email protected]>
bumping up oras-go to v2.5.0 along with golang version to v1.21. Signed-off-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 73.43% 80.29% +6.86%
==========================================
Files 24 33 +9
Lines 2507 2340 -167
==========================================
+ Hits 1841 1879 +38
+ Misses 526 324 -202
+ Partials 140 137 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, with a few suggestions left.
Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Patrick Zheng <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Co-authored-by: Junjie Gao <[email protected]> Signed-off-by: Pritesh Bandi <[email protected]>
Signed-off-by: Pritesh Bandi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with unit tests fixed.
Signed-off-by: Pritesh Bandi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit
This PR implements VerifyBlob functionality as per https://github.com/notaryproject/specifications/blob/main/specs/trust-store-trust-policy.md
This PRis ready for review