Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Timestamp #418

Merged
merged 105 commits into from
Jul 15, 2024
Merged

feat: Timestamp #418

merged 105 commits into from
Jul 15, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jun 27, 2024 •
edited
Loading

This PR adds timestamping support.

Resolves #78

@Two-Hearts
initial test
4b42738 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
fix trust store
ca5bba2 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolved conflicts
73ec77c 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
2937f68
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
f06d289
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
9819ba2
@Two-Hearts
initial commits
8e6bbdb 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
initial commits
b454646 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
d058046
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
1df563c
@Two-Hearts
updated to use tspclient-go
9cd5aaf 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolved conflicts
ef01821 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
e655c04
@Two-Hearts
updated tspclient-go
ea97a99 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
test
fa4eaaf 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
dc9c5fe 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
00d7dfd
@Two-Hearts
resolved conflicts
62bacd0 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
1f4bd5c
@Two-Hearts
update sign with timestamping
3b98cd7 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolved conflicts
09810a9 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update timestamp verification
e598416 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated timestmap
be2ea0e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated timestamp
c8f8e4e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolve conflicts
28e0166 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added tsa cert chain revocation check
200a071 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
6ab5a0e
@Two-Hearts
update tsa
53ee15c 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
added tsa ocsp check
e5aaefe 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated timestamping
2e674e4 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts dismissed stale reviews from JeyJeyGao and shizhMSFT via 45f3495 July 11, 2024 07:29
shizhMSFT
shizhMSFT previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi reviewed Jul 12, 2024
View reviewed changes
signer/signer.go Show resolved Hide resolved
verifier/trustpolicy/trustpolicy.go Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
priteshbandi
priteshbandi reviewed Jul 12, 2024
View reviewed changes
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
signer/signer.go Show resolved Hide resolved
@Two-Hearts
updated per code review
5c1a4b7 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts dismissed stale reviews from JeyJeyGao and shizhMSFT via 5c1a4b7 July 12, 2024 07:25
@Two-Hearts
updated per code review
bf97c57 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
fe59bc2
@Two-Hearts
updated per code review
7d03fd2 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
e0eb1b6 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
update
c962941 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated log
e50cf0a 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Jul 12, 2024
View reviewed changes
signer/signer.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
b94b3fd 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts mentioned this pull request Jul 15, 2024
Open
priteshbandi
priteshbandi approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit b525831 into notaryproject:main Jul 15, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the tsa branch July 15, 2024 04:40
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reenable timestamping for signing and verification
4 participants
@Two-Hearts @priteshbandi @shizhMSFT @JeyJeyGao