-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
desktop.exe
credential store is not supported in WSL
#696
Comments
desktop.exe
credential store is not support WSLdesktop.exe
credential store is not supported WSL
desktop.exe
credential store is not supported WSLdesktop.exe
credential store is not supported in WSL
The current behavior is that for The bug should be fixed at the |
Related issue on |
So, I am confused about what the behavior should be. I would not expect a credential helper to react to an explicit notation login request. That is not why a credential helper is normally used. I would expect that:
Some credential helpers error when an explicit Login op is attempted and the credential helper is configured locally. This is seen in Notation and Docker. Is that not the case? I just see Notation Login/Logout ops separate ops than signing/verifying/listing, with separate needs for credentials and helpers. |
Thanks @jimmyraywv
From the requirement point of view,
Hope this can answer your questions that why the behavior is different between different commands. It's a bug in |
@yizha1 - A couple of more thoughts.
|
Yes
When users use notation login/logout, and no Notation config for credential store. The mitigation is to manually create Notation
This is not relevant to this bug. Please check the answers to question 5, it may help.
Before RC-7, Notation still used credentials store to store the credentials securely. The login/logout behaviors are the same for credentials store. In RC-7 Notation support reading credentials from docker config file if credentials store is not configured. However, there is a bug in RC-7 that Notation only checks its own config, not docker config.
|
Thanks @yizha1 .So you are saying before RC-7/RC-6 one had to configure the Notation config.json file if they wanted to use a credential help. With RC-7/RC-6, we aimed to simplify that by having Notation look at docker.config automatically, but due to the bug, login/logout commands still don't automatically look at docker;s config.json |
@iamsamirzon Before RC-7/RC-6, notation commands support using credentials store from docker config, but this bug broke the experience for |
…store (#712) Fixes: #696 Signed-off-by: Sylvia Lei <[email protected]>
What is the areas you experience the issue in?
Notation CLI
What is not working as expected?
Docker Desktop was installed on Windows, but I cannot login by
![image](https://private-user-images.githubusercontent.com/43160897/241883774-56bf3b02-6a9d-423d-982c-5baf62f924c6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3MzMxNjAsIm5iZiI6MTcyNTczMjg2MCwicGF0aCI6Ii80MzE2MDg5Ny8yNDE4ODM3NzQtNTZiZjNiMDItNmE5ZC00MjNkLTk4MmMtNWJhZjYyZjkyNGM2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDE4MTQyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZjMDUzZDk5NGRlMzNmY2RlMGRjMmVjNTNiZGIxMDMxOWNlZjllNmU0ZTg3N2Q5MGFhZTVkMmVkYjNlYzk1ZGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NS15s90LR-Oo7sVLAR8ipAddMkOH4pLcOyDlFDb8MX4)
notation login
commandWhat did you expect to happen?
I should login with
notation login
command successfully because I have installed the Docker Desktop with desktop.exe credential store.Here is my docker config:
Here is the files under notation config directory:
$ ~/.config/notation
How can we reproduce it?
notation login
in WSLDescribe your environment
Windows 11 with WSL2 Ubuntu 22.04
What is the version of your Notation CLI or Notation Library?
Notation v1.0.0-rc.7
The text was updated successfully, but these errors were encountered: