Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Notary v2 reference in CLI repo #603

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Mar 28, 2023

This PR updates notary v2 to notation.

@yizha1 please confirm if this is what you are expecting.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #603 (9b74dfc) into main (124c6c8) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   34.36%   34.36%           
=======================================
  Files          32       32           
  Lines        1848     1848           
=======================================
  Hits          635      635           
  Misses       1192     1192           
  Partials       21       21           
Impacted Files Coverage Δ
cmd/notation/main.go 0.00% <0.00%> (ø)
cmd/notation/version.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yizha1
Copy link
Contributor

yizha1 commented Mar 28, 2023

Maybe we can change the title to chore: remove Notary v2 reference in CLI repo

@patrickzheng200 patrickzheng200 changed the title update: notary v2 to notation in CLI repo chore: remove Notary v2 reference in CLI repo Mar 28, 2023
cmd/notation/version.go Outdated Show resolved Hide resolved
specs/commandline/version.md Outdated Show resolved Hide resolved
specs/commandline/version.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200 patrickzheng200 merged commit d961278 into notaryproject:main Mar 30, 2023
@patrickzheng200 patrickzheng200 deleted the version branch March 30, 2023 01:33
duffney pushed a commit to duffney/notation that referenced this pull request Mar 30, 2023
This PR updates `notary v2` to `notation`.

Signed-off-by: Josh Duffney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Need to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants