doc: improve error output in notation key and notation cert #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feynman Zhou <[email protected]>
FeynmanZhou
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
patrickzheng200,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 34.43% 33.06% -1.37%
==========================================
Files 32 32
Lines 1844 2011 +167
==========================================
+ Hits 635 665 +30
- Misses 1188 1324 +136
- Partials 21 22 +1 see 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shizhMSFT
reviewed
Mar 30, 2023
yizha1
reviewed
Mar 31, 2023
Signed-off-by: Feynman Zhou <[email protected]>
byronchien
reviewed
Apr 4, 2023
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
Signed-off-by: Feynman Zhou <[email protected]>
yizha1
reviewed
Apr 18, 2023
yizha1
reviewed
Apr 18, 2023
shizhMSFT
changed the title
Signed-off-by: Feynman Zhou <[email protected]>
JeyJeyGao
reviewed
Apr 21, 2023
Signed-off-by: Feynman Zhou <[email protected]>
FeynmanZhou
dismissed stale reviews from priteshbandi, yizha1, and patrickzheng200
via
b83088b
|
Hi @notaryproject/notaryproject-notation-maintainers , I resolved @JeyJeyGao 's comment. Could you pls review it again? Thanks |
|
@priteshbandi There was a small update after your last approval. Could you re-approve this PR? Thanks! |
priteshbandi
pushed a commit
that referenced
this pull request
May 25, 2023
This PR is based on spec changes in here: #606. --------- Signed-off-by: Patrick Zheng <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CLI spec to improve error output in
notation keyandnotation certand resolve the UX problem in #604