Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the examples of sign and verify #650

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Apr 26, 2023

This PR updates long messages of sign and verify.
When NOTATION_EXPERIMENTAL variable is not set, experimental examples will be hidden.

Resolves #645.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Merging #650 (bd8a949) into main (2e56dd4) will increase coverage by 0.16%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   33.16%   33.33%   +0.16%     
==========================================
  Files          32       32              
  Lines        2014     2019       +5     
==========================================
+ Hits          668      673       +5     
  Misses       1324     1324              
  Partials       22       22              
Impacted Files Coverage Δ
cmd/notation/list.go 28.94% <100.00%> (ø)
cmd/notation/sign.go 43.06% <100.00%> (+1.27%) ⬆️
cmd/notation/verify.go 32.30% <100.00%> (+1.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
cmd/notation/verify.go Outdated Show resolved Hide resolved
cmd/notation/sign.go Outdated Show resolved Hide resolved
cmd/notation/internal/cmdutil/longMessage.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 4589c83 into notaryproject:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Need to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples were shown for experimental feature
5 participants