-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip non-applicable unit tests on Windows #651
test: skip non-applicable unit tests on Windows #651
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 33.16% 33.16%
=======================================
Files 32 32
Lines 2014 2014
=======================================
Hits 668 668
Misses 1324 1324
Partials 22 22 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Junjie Gao <[email protected]>
4077014
to
7340c34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title should be test: skip non-applicable unit tests on Windows
.
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix unit test:
Test:
Test output:
Signed-off-by: Junjie Gao [email protected]